search

camptocamp / cgxp

22 stars 22 forks source link

Backport no data value option to profile plugin into 1.5 #1055

Closed rbovard closed 8 years ago

rbovard commented 8 years ago

Is it possible to backport #951 into 1.5 branch?

sbrunner commented 8 years ago

Done :-)

rbovard commented 8 years ago

Cool, thanks a lot!

rbovard commented 8 years ago

Hum, I just tested and there is a missing ); here https://github.com/camptocamp/cgxp/blob/1.5/core/src/script/CGXP/plugins/Profile.js#L475

rbovard commented 8 years ago

There are other JS errors...

I think we also need to backport those two:

I'm sorry about that, I thought it was straightforward...

sbrunner commented 8 years ago

OK, just done :-)

rbovard commented 8 years ago

Thanks @sbrunner, no more JS errors :)

But I think there is an issue with the feature, see https://github.com/camptocamp/cgxp/pull/951#issuecomment-160554011