camptocamp / cgxp

22 stars 22 forks source link

Allow empty content in FTS colorpicker #1068

Closed asaunier closed 7 years ago

asaunier commented 8 years ago

Reproducible in https://geomapfish-demo.camptocamp.net/1.6/

See 39dd0cc2-a7f9-11e5-9fb1-27b48b4eba4a

That's because when selecting a color, the field content is set to "": https://github.com/camptocamp/cgxp/blob/1.6/core/src/script/CGXP/plugins/FullTextSearch.js#L281 which triggers the default blank content detection.

This PR makes sure the detection is skipped.

By the way in Firefox when clicking on the colorpicker, a text editing cursor appears in the field (not in Chrome). See: d7b947c8-a7fc-11e5-8188-d680e7421e1d

I have not found out yet how to prevent this. Anyone has a tip?

sbrunner commented 8 years ago

Looks good, merge :-)

svavoi commented 8 years ago

With Version 1.6.8 this issue is not resolved completely. The red border is gone but in Firefox and IE11 when clicking on the colorpicker, the text editing cursor still appears in the field.