search

camptocamp / cgxp

22 stars 22 forks source link

print plugin - printExport returns an object #1080

Closed kalbermattenm closed 8 years ago

kalbermattenm commented 8 years ago

printExport() returns an object, not an array (if used with a featureGrid... I do not know what happens with a featureWindow....).

I corrected this for version 2 (instance still using mapfish print 2)

Please review

Replaces https://github.com/camptocamp/cgxp/pull/1079

sbrunner commented 8 years ago

This should also be changed to ... = {}; https://github.com/camptocamp/cgxp/blob/9f3034eb44f67bdf12fd737f90859db7290d0bff/core/src/script/CGXP/plugins/FeaturesWindow.js#L613

kalbermattenm commented 8 years ago

Commit was amended, thanks @sbrunner

sbrunner commented 8 years ago

Thanks @kalbermattenm , I will merge it when the Travis tests pass :-)

kalbermattenm commented 8 years ago

Could someone please merge this ?

Thanks !

sbrunner commented 8 years ago

Done :-)

kalbermattenm commented 8 years ago

Thanks a lot @sbrunner !