search

camptocamp / cgxp

22 stars 22 forks source link

WMS Browser does not work on Cartoriviera #584

Closed gnerred closed 10 years ago

gnerred commented 11 years ago

To reproduce :

1°/ Go to http://map.cartoriviera.ch 2°/ Try to add an external WMS layer -> js error

Thanks to take 3 or 4 hours to analyse and try to solve this bug.

sbrunner commented 11 years ago

The issue #548 should probably also be fixed in the same time.

pgiraud commented 11 years ago

It looks like OWSCommon/v_1_0_0.js is missing in the build or actually that it's not included anymore. It's included when you add the QueryBuilder which includes WFS/v1_1_0.js, which itself includes WFST/v1_1_0.js, which finally includes OWSCommon/v_1_0_0.js. I still don't know why this version is required though.

As a workaround, you can explicitely add OWSCommon/v1_0_0.js in app.cfg.

sbrunner commented 11 years ago

Shouldn't this dependence by added here ? https://github.com/openlayers/openlayers/blob/master/lib/OpenLayers/Format/WMSCapabilities/v1.js#L7-L9 or in our WMSBrowser plugin ?

gnerred commented 11 years ago

Many thanks @pgiraud, that (finally) solves my problem !!

sbrunner commented 10 years ago

Will be fixed by https://github.com/openlayers/openlayers/pull/1165

sbrunner commented 10 years ago

Related to: https://github.com/openlayers/openlayers/pull/1186 + https://github.com/openlayers/openlayers/pull/1165 (with an include in place of requires)