search

camptocamp / cgxp

22 stars 22 forks source link

Add undo feature in Editing plugin #997

Closed arnaud-morvan closed 9 years ago

sbrunner commented 9 years ago

I stop my review because I see many boolean operation on non boolean type, this should be avoid ...

arnaud-morvan commented 9 years ago

I've removed all boolean tests on feature.state, replaced by explicit tests. I've initialized and documented this.previous and this.undoStack properties.

sbrunner commented 9 years ago

Excellent, for me it's OK to merge :-)