search

camptocamp / inkmap

A library for generating high-quality, printable maps on the browser.
Other
86 stars 17 forks source link

Examples add timestamp #25

Closed ghost closed 3 years ago

ghost commented 3 years ago

DEMO: Updating file-name: Adding timestamp, such that I can save more than one map per day :-) Also factored it out in a new function to have it only at one place.

jahow commented 3 years ago

Hey! Thanks for doing this. There is one thing that is important to me here: the examples code is visible in the demo page and is actually a showcase of the library for the developers.

That is why I originally strived to only use imports from the inkmap library and keep the line count and complexity to the minimum. As such, having a file name that was not unique every time was not a big concern IMO, the browser would just append (1), (2) etc. to it.

On the other hand, importing a function from another module (that will not be shown in the demo page) makes things a bit more opaque, and may render the code less readable.

ghost commented 3 years ago

OK, closing the PR.