search

camptocamp / ngeo

Library combining OpenLayers and AngularJS
https://camptocamp.github.io/ngeo/master/examples
MIT License
135 stars 87 forks source link

Transifex account may be corrupted #2303

Closed pgiraud closed 7 years ago

pgiraud commented 7 years ago

The password provided at the following line allows anyone to change the translation in Camptocamp's transifex account. https://github.com/camptocamp/ngeo/blob/master/Makefile#L908

sbrunner commented 7 years ago

This account don't have any rights ...

pgiraud commented 7 years ago

I wouldn't be so sure about this. https://www.transifex.com/camptocamp/geomapfish/translate/#fr/c2cgeoportal-2_0/97677343?qt=caca

pgiraud commented 7 years ago

This user doesn't have rights to change reviewed translations at least.

sbrunner commented 7 years ago

Every body can do it ...

pgiraud commented 7 years ago

Are we sure that only reviewed translations are pulled from transifex? If this is the case, then we can close this issue.

pgiraud commented 7 years ago

It looks like we don't use "--mode=reviewed" when calling tx pull so all the translations are pulled. https://github.com/camptocamp/ngeo/blob/master/Makefile#L947-L953

sbrunner commented 7 years ago

+1, we should add it :-)