search

camptocamp / ngeo

Library combining OpenLayers and AngularJS
https://camptocamp.github.io/ngeo/master/examples
MIT License
135 stars 87 forks source link

Redirect to desktop message #2354

Closed rbovard closed 7 years ago

rbovard commented 7 years ago

Where is the redirect to desktop message? Like it was in 1.6 with a tablet:

Vous utilisez la version pour mobile. Vous pouvez aussi consulter la version standard.

sbrunner commented 7 years ago

Not sure the it will be created ...

gnerred commented 7 years ago

This message is important. If not, the user will not be able to open desktop application on a tablet.

sbrunner commented 7 years ago

We should probably use the screen width > 750

sbrunner commented 7 years ago

and height > 500 (or > 750?)

gnerred commented 7 years ago

The redirect message does not work on my 2.1.2.dev3 version : https://preprod.cartoriviera.ch/v2/ When I click on "standard version", the mobile application is still reloaded. A configuration problem on my side or an issue ? @ger-benjamin

ger-benjamin commented 7 years ago

It doesn't work for me neither. To be exact, I think that it work but the desktop.html redirect immediately to the mobile.html again. I think that because that work on a desktop device (remove the "display:none; on the div to see the redirection message on a desktop device")

It should have a "no_redirect" to be interpreted by this line and don't do the redirection: https://github.com/camptocamp/demo_geomapfish/blob/master/demo/templates/desktop.html#L8

rbovard commented 7 years ago

Fixed, thanks.