camptocamp / ngeo

Library combining OpenLayers and AngularJS
https://camptocamp.github.io/ngeo/master/examples
MIT License
135 stars 87 forks source link

How to remove the link to reset password #3202

Closed rbovard closed 6 years ago

rbovard commented 6 years ago

What is the HTML attribute to remove the link to reset password? I think it should be something to set resetPasswordModalShown

Thanks.

kalbermattenm commented 6 years ago

Are you looking for:

<gmf-authentication gmf-authentication-allow-password-change="false"></gmf-authentication>

?

rbovard commented 6 years ago

@kalbermattenm Thanks but where did you find it? I looked there https://camptocamp.github.io/ngeo/2.1/apidoc/gmf.authenticationDirective.html

fredj commented 6 years ago

This option is only available in ngeo >= 2.2: https://camptocamp.github.io/ngeo/2.2/apidoc/gmf.authenticationDirective.html

rbovard commented 6 years ago

Ouch... Any chance to backport it?

BTW: So I looked at the good place :)

ybolognini commented 6 years ago

If this feature is a 2.2 feature then I think it should stay in 2.2.

Do you plan to migrate to 2.2?

rbovard commented 6 years ago

The change of password or the ablitity to hide the the password change? Because with no SMTP, the error is brutal and it's impossible to hide it... See https://map.nyon.ch/mobile/

We just go live this weekend on 2.1, so now we're stabilizing the situation... And we are already confronted to this really annoying issue https://github.com/camptocamp/ngeo/issues/3036, wich will not be fixed in 2.1 branch as discussed with @yjacolin

rbovard commented 6 years ago

Any news on this one?

rbovard commented 6 years ago

After upgrade to 2.2.1 it doesn't work with:

      <gmf-authentication id="login" class="gmf-mobile-nav-slide" data-header-title="{{'Login' | translate}}"
        gmf-mobile-nav-back="authCtrl.gmfUser.username !== null"
        gmf-authentication-allow-password-change="false">
      </gmf-authentication>
kalbermattenm commented 6 years ago

You are right, I have the same problem and I am using the same option : image

rbovard commented 6 years ago

Thanks for the confirmation...

rbovard commented 6 years ago

@fredj Did you plan to fix this issue?

fredj commented 6 years ago

@kalbermattenm gmf-authentication-allow-password-change="false" disable the "Change password" button when you're logged in, not the "Password forgotten?" when you're not already logged in.

rbovard commented 6 years ago

So it's not possible to disable the button to reset password??

fredj commented 6 years ago

@rbovard not for now

kalbermattenm commented 6 years ago

@kalbermattenm gmf-authentication-allow-password-change="false" disable the "Change password" button when you're logged in, not the "Password forgotten?" when you're not already logged in.

Oh right... Sorry for the noise !

rbovard commented 6 years ago

Nobody noticed it until today ;)

kalbermattenm commented 6 years ago

Yeah... But @fredj has quite good eyes, these kind of "I do not miss a thing" eyes... 😃

fredj commented 6 years ago

fixed with #3262

rbovard commented 6 years ago

Thanks, it's working.