camptocamp / puppet-archive

Apache License 2.0
28 stars 102 forks source link

Archive::Extract does not respect `$extract_dir` #46

Open rymndhng opened 9 years ago

rymndhng commented 9 years ago

In the file extract.pp

      $extract_zip    = "unzip -o ${src_target}/${name}.${extension} -d ${target}"
      $extract_targz  = "tar --no-same-owner --no-same-permissions --strip-components=${strip_components} -xzf ${src_target}/${name}.${extension} -C ${target}"
      $extract_tarbz2 = "tar --no-same-owner --no-same-permissions --strip-components=${strip_components} -xjf ${src_target}/${name}.${extension} -C ${target}"

These ${target} should be ${extract_dir}

That said: I'm more concerned with how this module isn't consistent with how the parameters should be used. I much prefer having a single $target to extract to because that's conceptually easier to follow.

joshuaspence commented 9 years ago

+1

aman-ttc commented 9 years ago

+1.

What is the status of this? I can provide a PR if necessary

aman-ttc commented 9 years ago

bump...