Open rymndhng opened 9 years ago
In the file extract.pp
$extract_zip = "unzip -o ${src_target}/${name}.${extension} -d ${target}" $extract_targz = "tar --no-same-owner --no-same-permissions --strip-components=${strip_components} -xzf ${src_target}/${name}.${extension} -C ${target}" $extract_tarbz2 = "tar --no-same-owner --no-same-permissions --strip-components=${strip_components} -xjf ${src_target}/${name}.${extension} -C ${target}"
These ${target} should be ${extract_dir}
${target}
${extract_dir}
That said: I'm more concerned with how this module isn't consistent with how the parameters should be used. I much prefer having a single $target to extract to because that's conceptually easier to follow.
$target
+1
+1.
What is the status of this? I can provide a PR if necessary
bump...
In the file extract.pp
These
${target}
should be${extract_dir}
That said: I'm more concerned with how this module isn't consistent with how the parameters should be used. I much prefer having a single
$target
to extract to because that's conceptually easier to follow.