search

camptocamp / pyramid_closure

Helpers for working with the Closure tools in a Pyramid project
0 stars 4 forks source link

Fix build from fresh clone #47

Closed gberaudo closed 9 years ago

gberaudo commented 9 years ago

Add missing jquery extern and fixed typo in Makefile.

gberaudo commented 9 years ago

Fixes #46

elemoine commented 9 years ago

It looks like ProjectSample still misses externs when compared to the scaffold, no?

gberaudo commented 9 years ago

@elemoine, I know understand ProjectSample is the result of the .build/venv/bin/pcreate -s pyramid_closure ProjectSample command. What is it for?

elemoine commented 9 years ago

Just have an example we can test.

gberaudo commented 9 years ago

It is a bit confusing to have it in the source tree. What about renaming it toGeneratedProjectSample or eventually removing it?

Anyway, I updated the PR with the result of the pcreate command and it is ready for merging.

elemoine commented 9 years ago

I don't want to remove it. It's very convenient for testing.

Please merge.

gberaudo commented 9 years ago

@elemoine, I tested by removing the ProjectSample, recreating it and running git diff. Is it the intended way?

elemoine commented 9 years ago

You don't need to remove it. You can apply the template on an existing project.

fredj commented 9 years ago

@elemoine, I tested by removing the ProjectSample, recreating it and running git diff. Is it the intended way?

This is also how I refresh ProjectSample.

gberaudo commented 9 years ago

I tested with a modified build.json and it is not overwritten on a call to pcreate. I need to remove it, or more safely remove the entire directory to get it recreated.

elemoine commented 9 years ago

There's an --overwrite option you can use.