campus-experts / hackday-2017

Campus Experts Hackday, 21st-22nd October 2017
2 stars 3 forks source link

Welcome - GitHub Etiquette #6

Open joenash opened 6 years ago

joenash commented 6 years ago

There are numerous aspects of etiquette we want to enforce. Some are true for all of GitHub, some are true for experts.

In particular for experts, we want to discourage students adding reviewers, or tagging reviewers, or asking for review. Prefect should post a warning to students who do this.

KaiFish commented 6 years ago

I think a video to guide students through their first pull request and explain the way the reviewing system works would be help a lot with these issues mentioned it in #4

joenash commented 6 years ago

@kaifish I don’t want us to start getting into details about how the reviewing system works publicly, because it makes it harder to change and also sets rigid expectations for performance that we might struggle to provide. However I do definitely want to provide clearer guidance on the first PR, might make a series of gifs to embed in the instructions

KaiFish commented 6 years ago

I didn't mean details, more so telling people to tag it properly and leave it alone, and you will see reviews eventually. so that you don't get blasted with comments from new people asking when it will be reviewed.

joenash commented 6 years ago

Gotcha 👍