search

campuspress / divi-accessibility

Improve Divi accessibility in accordance with WCAG 2.0 guidelines.
https://wordpress.org/plugins/accessible-divi/
GNU General Public License v2.0
127 stars 29 forks source link

Improvements Not Applied to Mobile Menu #36

Closed thewebtailors closed 3 years ago

thewebtailors commented 4 years ago

It seems like depending on from which location Divi outputs the mobile menu, the hamburger menu icon classes differ:

(e.g. output through Divi/includes/builder/module/FullwidhtMenu.php or through Divi/includes/builder/module/Menu.php).

The divi-accessibility plugin however only seems to improve the accessibility for "mobile_menu_bar_toggle". Can you also add support for the class mobile_menu_bar class?

alexstine commented 4 years ago

@vladislavbailovic Could you please have a look?

thewebtailors commented 4 years ago

For right now I added the following code to my function.php file to make the menu controllable via keyboard: //menu accessibility fix add_action('wp_footer', function() { ?><script>document.querySelector('.mobile_menu_bar').classList.add('mobile_menu_bar_toggle');</script><?php },-10); But if you could add support for it from within your plugin that would be even better.

stpha6 commented 3 years ago

I've added the toggle to my mobile menu bar, but I'm still unable to navigate to it via the keyboard - is there any additional info out there on making the divi mobile menu accessible from a keyboard? I've been searching, but thought I'd ask here as well.

alexstine commented 3 years ago

Hello everyone,

I just merged a fix in to the plugin and a new release is coming soon. Could you please try it out and see if this fixes your problem? I will link the release when I have published it.

Thanks.

alexstine commented 3 years ago

Link to release: https://github.com/campuspress/divi-accessibility/releases/tag/2.0.3

stpha6 commented 3 years ago

I just tested, and the return key works, but not space bar for the mobile menu - but this is a great improvement! I was able to hit enter, and tab through all the menu items and when it was through the items, it closes the menu and continues down the page.

alexstine commented 3 years ago

@TxSadhu Can you make this work with space bar?

Thanks to @stpha6 for testing.

alexstine commented 3 years ago

Hello all,

Anyone up for another test? Here's the release. I tested it myself and it seems to be working fine.

https://github.com/campuspress/divi-accessibility/releases/tag/2.0.4

Thanks.

stpha6 commented 3 years ago

looks like spacebar functionality works now!

Thanks!

On Mon, Apr 26, 2021 at 11:06 AM Alex Stine @.***> wrote:

Hello all,

Anyone up for another test? Here's the release. I tested it myself and it seems to be working fine.

https://github.com/campuspress/divi-accessibility/releases/tag/2.0.4

Thanks.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/campuspress/divi-accessibility/issues/36#issuecomment-826910589, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2FD3V7R36OYTPSTAU5D2LTKV6PLANCNFSM4RICWEMQ .

-- Maryann Reissig https://maryannreissig.com https://gvrc.org @stpha6 https://twitter.com/stpha6

"Peace is the language that everyone understands..."