search

camsas / firmament

The Firmament cluster scheduling platform
Apache License 2.0
415 stars 79 forks source link

[build] ext build target marked as complete even when it fails #2

Closed sebastian closed 12 years ago

sebastian commented 12 years ago

If you run make ext and it fails, for example because of missing dependencies, the build system seems to believe the step has been successfully completed. If you run make ext again, even without having made any changes, I get: make: 'ext' is up to date.

I am running Ubuntu 11.10 gnu make: 3.81

ms705 commented 12 years ago

Yeah, I noticed that before. Probably requires some make-fu to fix this -- I'll look into it. We don't want to make ext PHONY, because we don't want to build it every time. The most likely answer, I think, is to have the fetch-externals script create a flag file that is also the output of the ext target. Then, as long as that file doesn't exist, we should end up rebuilding ext.

ms705 commented 12 years ago

Resolved in commits 03a20e54d40d6ec707dad6a076e5057c56b7e27a and 6fca99e14c66b0cc0e5d11f16f9866f5fc699fdc.