camsaul / methodical

Functional and flexible multimethods for Clojure. Nondestructive multimethod construction, CLOS-style aux methods and method combinations, partial-default dispatch, easy next-method invocation, helpful debugging tools, and more.
Eclipse Public License 2.0
295 stars 19 forks source link

Ambiguous primary method errors include multimethod name #131

Closed camsaul closed 2 years ago

camsaul commented 2 years ago

Fixes #126

This also changes the error thrown on ambiguous methods from an IllegalArgumentException to a clojure.lang.ExceptionInfo, and the ex-data map now includes the namespace, file, and line where each of the conflicting methods is defined.

codecov[bot] commented 2 years ago

Codecov Report

Base: 87.09% // Head: 86.98% // Decreases project coverage by -0.10% :warning:

Coverage data is based on head (ec75cb5) compared to base (c223cab). Patch coverage: 81.81% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #131 +/- ## ========================================== - Coverage 87.09% 86.98% -0.11% ========================================== Files 22 22 Lines 1240 1245 +5 Branches 68 70 +2 ========================================== + Hits 1080 1083 +3 Misses 92 92 - Partials 68 70 +2 ``` | [Impacted Files](https://codecov.io/gh/camsaul/methodical/pull/131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Cam+Saul) | Coverage Δ | | |---|---|---| | [src/methodical/impl.clj](https://codecov.io/gh/camsaul/methodical/pull/131/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Cam+Saul#diff-c3JjL21ldGhvZGljYWwvaW1wbC5jbGo=) | `81.70% <ø> (ø)` | | | [src/methodical/impl/dispatcher/standard.clj](https://codecov.io/gh/camsaul/methodical/pull/131/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Cam+Saul#diff-c3JjL21ldGhvZGljYWwvaW1wbC9kaXNwYXRjaGVyL3N0YW5kYXJkLmNsag==) | `78.18% <81.81%> (-0.87%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Cam+Saul). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Cam+Saul)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.