Functional and flexible multimethods for Clojure. Nondestructive multimethod construction, CLOS-style aux methods and method combinations, partial-default dispatch, easy next-method invocation, helpful debugging tools, and more.
Eclipse Public License 2.0
294
stars
19
forks
source link
Refactor Move Describable to methodical.interface #137
[x] Tests and linters pass. You can run all of the tests and linters locally with
./scripts/lint-and-test.sh
GitHub Actions will also run these same tests against your PR.
[x] Make sure you've included new tests for any new features or bugfixes.
[x] New features are documented, or documentation is updated appropriately for any changed features.
[x] Carefully review your own changes and revert any superfluous ones. (A good example would be moving words in the
Markdown documentation to different lines in a way that wouldn't change how the rendered page itself would
appear. These sorts of changes make a PR bigger than it needs to be, and, thus, harder to review.)
Of course, indentation and typo fixes are not covered by this rule and are always appreciated.
[x] Include a detailed explanation of what changes you're making and why you've made them. This will help me
understand what's going on while we review it.
Once you've done all that, open a PR! Thanks for your contribution!
This PR closes #128
I have moved the contents of the file methodical.util.describe to methodical.interface.
I have refactored the occurrences of Describable as well.
And I've deleted the methodical.util.describe namespace.
The diff looks bigger than it is because of my formatter. I couldn't find a formatter in the deps.edn file (so let me know if you want me to reformat it with a specific formatter with a specific config.
Thanks for contributing to Methodical. Before open a pull request, please take a moment to:
[x] Tests and linters pass. You can run all of the tests and linters locally with
./scripts/lint-and-test.sh
GitHub Actions will also run these same tests against your PR.
[x] Carefully review your own changes and revert any superfluous ones. (A good example would be moving words in the Markdown documentation to different lines in a way that wouldn't change how the rendered page itself would appear. These sorts of changes make a PR bigger than it needs to be, and, thus, harder to review.)
Of course, indentation and typo fixes are not covered by this rule and are always appreciated.
Once you've done all that, open a PR! Thanks for your contribution!
This PR closes #128
methodical.util.describe
tomethodical.interface
.methodical.util.describe
namespace.