search

camsong / chrome-github-mate

Chrome extension to make single file download effortless and with more features
https://chrome.google.com/webstore/detail/github-mate/baggcehellihkglakjnmnhpnjmkbmpkf
MIT License
360 stars 63 forks source link

Sticky side-panel for favorites & markdown-outline #15

Closed zbycz closed 8 years ago

zbycz commented 8 years ago

Hi,

I really often needed to switch several repositories on github, and opening bookmarks seemed unhandy. So i thought it would be cool to add favorites in a fixed-position sidebar. Then I also wanted to quickly jump around markdown documents, so I added @dbkaplun's github-markdown-outline-extension (MIT License) also to the panel. Which is kind of handy - because you see it fixed-position all the time.

Here is the result: screen shot 2016-04-02 at 10 15 32

Also on that small screen the panel auto-hides, on bigger screen remains open. And when the outline is too big, another independent scrollbar is shown.

The code is kind of crappy - I just coded it as quickly as I could :-) Still I`d be happy to merge to main master.. Otherwise please tell me what to change.

camsong commented 8 years ago

Great @zbycz, I definitely like this. I'll merge this PR first and release soon after tweak the code.

zbycz commented 8 years ago

Thank you, Cam! Will be happy to see it out.

camsong commented 8 years ago

Released with https://github.com/rubyerme/chrome-github-mate/releases/tag/0.14.1

zbycz commented 8 years ago

Great! Two more things: 1) Maybe add the screenshot in the main README.md? 2) Unluckily - sticky panel gets under sticky issue sidebar - needs: z-index: 30; instead of 10 screen shot 2016-04-04 at 17 38 59

camsong commented 8 years ago
  1. added
  2. fixed in 0.14.2
camsong commented 8 years ago

The reason I don't like github-events-viewer as a default links is it's not easy to use right now. It requires user to input token, which is not easy for most users. If you can make it better looking and not show all events data inside the page, not through a new tab, I would like to add it back

zbycz commented 8 years ago
  1. Well, user token is very easy - just beside the input, there is a link where user clicks two times. I dont see it difficult.
  2. Although I see a security concern - the page could be hacked to give out the token. A solution could be to use cdn version which is cached forever, so nobody nor I could tamper with it.
  3. Design is little "uncool".. I take it as the only valid argument :-)
  4. why not showing the events data in the page? thats the purpose :-)

[continuing discussion from commit]