camspiers / luarocks

Easily install luarocks with lazy.nvim
The Unlicense
17 stars 7 forks source link

fix: higher rock compatibility, build.lua typo #5

Open vhyrro opened 6 months ago

vhyrro commented 6 months ago

This PR adds two fixes:

jaredmontoya commented 6 months ago

As it is said in the readme: An up-to-date Neovim nightly (>= 0.10) installation is a requirement. Because luarocks.nvim does not target non-nightly neovim at the moment, commit 50b9f43 can be reverted. luarocks.nvim does not work on non nightly neovim due to some other functions that are only available in nightly so there is no point in not using other nightly-only functions like vim.fs.joinpath. You certainly can create a fork that works on neovim 0.9.5 but I am not sure if this is your intention and nightly will eventually become released so there is no point in doing that unless we want to start using luarocks.nvim as the cure for all luarocks problems with lazy.nvim in plugins for older neovim versions before neovim 0.10 is released.

Unless of course you mean that vim.fs.joinpath will be removed on 0.10's release.

vhyrro commented 6 months ago

@jaredmontoya I realized that lowering the requirement down to the latest Neovim stable is actually quite trivial which is why I reverted that commit. I have another branch, more-fixes, which completely eliminates the nightly requirement.

The more people start using luarocks the better :)

jaredmontoya commented 6 months ago

That's awesome!