[WIP] feat: allow opts to be nil in snap.run

camspiers / snap

A fast finder system for neovim.

The Unlicense

483 stars 16 forks source link

[WIP] feat: allow opts to be nil in snap.run #55

Closed akinsho closed 3 years ago

akinsho commented 3 years ago

This PR allows the third argument to snap.map to be nil in case a user does not want to create a command for a particular mapping. Without this change, the user must at least pass in an empty table.

camspiers commented 3 years ago

Thanks! I haven't tested it but it doesn't look right to me. Will check soon

camspiers commented 3 years ago

https://github.com/camspiers/snap/commit/2e65f787e45c525e330c6b8d091164b5ed1fc4f8

Closed in ^ apologies for changing the way you implemented it, but I think yours has a bug, but the bug I introduced is bad so it needs to be fixed immediately.

akinsho commented 3 years ago

Awesome, thanks for the fix @camspiers 👍🏾. No worries mine did have a bug and I was still looking around for the right syntax to make it work