Add ".Values.extraEnvs" to Deployment and set default .extraEnvs to {}

camunda-community-hub / camunda-7-community-helm

Camunda public Kubernetes Helm repo and charts

Apache License 2.0

39 stars 38 forks source link

Add ".Values.extraEnvs" to Deployment and set default .extraEnvs to {} #11

Closed scila1996 closed 2 years ago

scila1996 commented 3 years ago

Hi Camunda Team !

I have a issue when deploy and run camunda. It's here

https://forum.camunda.org/t/your-driver-may-not-support-getautocommit-or-setautocommit/16469/9

and solution are set testOnBorrow="true" . It's can be done with set DB_VALIDATE_ON_BORROW=true to container. And i was added extraEnvs to can be to customize more config over Container Environment, please merge my commit .

Many Thank !

CLAassistant commented 3 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Nguyen Thanh Trung seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

aabouzaid commented 3 years ago

Hi @scila1996 thanks for your contribution, it's pretty useful :+1:

Could you please rebase your change with the latest changes in the main branch? Also could you please document your change in the chart README file?

aabouzaid commented 2 years ago

Since no updates over a month, this feature has been added via PR no. #13