camunda-community-hub / camunda-7-community-helm

Camunda public Kubernetes Helm repo and charts
Apache License 2.0
39 stars 38 forks source link

All beta Ingress APIs are removed in Kubernetes v1.22 #33

Closed gnoejuan closed 2 years ago

gnoejuan commented 2 years ago
{{- if semverCompare ">=1.14-0" .Capabilities.KubeVersion.GitVersion -}}
apiVersion: networking.k8s.io/v1beta1
{{- else -}}
apiVersion: extensions/v1beta1
{{- end }}
kind: Ingress

Suggested action: Migrate to use the networking.k8s.io/v1 Ingress API, available since v1.19.

Source: https://kubernetes.io/blog/2021/07/14/upcoming-changes-in-kubernetes-1-22/

gnoejuan commented 2 years ago

Another solution would be to follow bitnami's solution

...
apiVersion: {{ template "common.capabilities.ingress.apiVersion" . }}
kind: Ingress
metadata:
...

Sources: https://github.com/bitnami/charts/blob/959769b33b27fe3dc28dbbcf2dc10b1227eab382/bitnami/harbor/templates/ingress/ingress.yaml

https://github.com/bitnami/charts/tree/master/bitnami/harbor#traffic-exposure-parameters

aabouzaid commented 2 years ago

@gnoejuan Thanks for your suggestion :+1: The 2nd solution is the way to go, do you like to make a PR for it?

gnoejuan commented 2 years ago

I would love to and am willing. I think I would need to learn how,exactly, Helm charts work, though! I only have experience with Helm via CLI and values.yaml lol.