Update ingress to stable version

camunda-community-hub / camunda-7-community-helm

Camunda public Kubernetes Helm repo and charts

Apache License 2.0

39 stars 38 forks source link

Update ingress to stable version #44

Closed sstolbov closed 1 year ago

CLAassistant commented 2 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

aabouzaid commented 2 years ago

@sstolbov Thanks for this fix. But since the API version is set conditionally as shown here: https://github.com/camunda-community-hub/camunda-helm/blob/a067b108e010c70e2b1312e6856aa85ef511afef/charts/camunda-bpm-platform/templates/ingress.yaml#L4

Also, the syntax should support the old and the new API version conditionally.

patrickegli commented 1 year ago

I submitted a fix that conditionally supports old and new API version. Can someone please have a look and merge the PR if acceptable?

See #59

thecampagnards commented 1 year ago

done in https://github.com/camunda-community-hub/camunda-7-community-helm/pull/59