Issue 33: process variables as out body

camunda-community-hub / camunda-platform-7-camel

Community Extension to add Apache Camel support for Camunda Platform 7

Apache License 2.0

82 stars 57 forks source link

Issue 33: process variables as out body #35

Closed stephanpelikan closed 2 years ago

stephanpelikan commented 6 years ago

see https://github.com/camunda/camunda-bpm-camel/issues/33

CLAassistant commented 5 years ago

All committers have signed the CLA.

berndruecker commented 3 years ago

@stephanpelikan Hey Stephan, somehow this got stuck - not sure on which side :-( Shall we catch up or close this PR now?

gwieshammer commented 2 years ago

I would be happy if this PR could find its way to be merged...

gwieshammer commented 2 years ago

I could avoid the usage of historyService by changing from startProcessInstanceByKey(...) to createProcessInstanceByKey(...).executeWithVariablesInReturn(), which runs basically the same code but its signature returns a ProcessInstanceWithVariables. Along with the code and tests I also shortened the README.md to not mention the historyLevel any more for the new copyVariablesToOutBody property.

berndruecker commented 2 years ago

Hey @gwieshammer - great - thx! LGTM - and it aligns much better with how the platform works out of the box. The biggest drawback is maybe that we now use "executeWithVariablesInReturn" all the time, which is at least a change to the status quo. But I can#t think of any problem with it - so I am happy to merge this now.