search

camunda-community-hub / camunda-platform-7-reactor

Event Driven process applications
https://camunda.github.io/camunda-bpm-reactor/
Apache License 2.0
80 stars 34 forks source link

Add missing task events #116

Closed boris-petrov closed 3 years ago

boris-petrov commented 3 years ago

The list of handled events doesn't contain update (as well as timeout) so setTaskListeners overwrites listeners for these events and they are gone. This is a major issue with master right now.

I guess that could also be the cause for #101.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

boris-petrov commented 3 years ago

@jangalinski - I believe the build is failing because of #113?

jangalinski commented 3 years ago

hm. I guessed that the PR branch was built already? Does it build locally on your side?

boris-petrov commented 3 years ago

No, I spent a bunch of time debugging my application before I found that it broke because of these missing event types so I just added them and made the PR. Sorry, should have tried building it first. I didn't know these events are missing on older versions of Camunda.

jangalinski commented 3 years ago

Ok, I will check, but can't do right now ... iirc updating this lib was not that easy ... I myself stopped using it after we added (almost) the same behavior to spring-boot directly ... that why this is a bit "rusty" ... but I am willing to keep it alive because it has some active users and I still like it ...