search

camunda-community-hub / community-action-maven-release

Opinionated GitHub action to release community projects to Maven Central
Apache License 2.0
7 stars 4 forks source link

Fix: Update uses tag #27

Closed celanthe closed 2 years ago

celanthe commented 2 years ago

Updated uses tags to reference most recent release of v1.0.9

Fixes: #25

berndruecker commented 2 years ago

As discussed in https://github.com/camunda-community-hub/community-action-maven-release/issues/25 this can be closed

celanthe commented 2 years ago

Hi @berndruecker! :) I just wanted to circle back on this as I'd love to get it merged to hopefully resolve #25. If you would be so kind as to review it whenever you get a moment, that would be amazing. Thank you so much!

berndruecker commented 2 years ago

Hi @celanthe - I am actually not sure if that fixes the problem. I am not deep enough in how Github actions work - and still pulled that the latest version is not just picked up as written in the docs (could the "v" in "v1.0.9" be a problem?). So if you think that helps I would say go ahead and we see what happens :-)

Or let me know if it make sense that I also look a bit deeper into this. I would love to get this resolved obviously :-)

celanthe commented 2 years ago

@berndruecker Fantastic! I did a bit more research into this, and for now I'm going to merge this and see if it resolves the issue in #25. If not, I'll open another issue and add my findings there so we can continue debugging this.

berndruecker commented 2 years ago

So, would now be a good time to test if anything changed @celanthe?

celanthe commented 2 years ago

@berndruecker definitely! That would be most appreciated! :)

berndruecker commented 2 years ago

Looks like it is still using an too old v1 if I don't specify to use v1.0.9, see https://github.com/camunda-community-hub/spring-zeebe/commit/bfb4677ac8c6bd0b470524b5a08c0109e47a619e leads to https://github.com/camunda-community-hub/spring-zeebe/runs/4372925957?check_suite_focus=true

celanthe commented 2 years ago

Thank you kindly for testing that out @berndruecker I'm so sorry to hear that it's not working as intended and am doing my best to look into possible solutions. I've got a new issue open for this over at https://github.com/camunda-community-hub/community-action-maven-release/issues/28 that I hope will help us get to the bottom of this! :)