search

camunda-community-hub / community-action-maven-release

Opinionated GitHub action to release community projects to Maven Central
Apache License 2.0
7 stars 4 forks source link

Release Action formats code #44

Closed jonathanlukas closed 1 year ago

jonathanlukas commented 1 year ago

The release action formats code, breaking our repo code format at exactly one point:

https://github.com/camunda-community-hub/camunda-7-to-8-migration/commit/ca58db474836a8f1bb5573393e1ad502197fb579#diff-62a928c9d3b1fa53272b907bdd4fd9d69a97aa2d9d44944f21b646a389ec8cda

We are using spotless, however adding -Dspotless.apply.skip (which skips the auto-formatter) as maven-release-options did have no effect.

Is there another plugin used from your side that would format code?

berndruecker commented 1 year ago

Hi @jonathanlukas - we updated the Maven parent pom and release action - can you try again with the latest parent (1.4.0) and release action if -Dspotless.apply.skip still does not work for your project?

I am closing this for now - please reopen if still a problem!

jonathanlukas commented 1 year ago

Hi @berndruecker , thank you for taking care. Actually, I configured this wrong some time ago and then changed it again to make it work, sorry for not updating the ticket.. :(