search

camunda-community-hub / community-action-maven-release

Opinionated GitHub action to release community projects to Maven Central
Apache License 2.0
7 stars 4 forks source link

Revert "fix: prevent second deployment to Maven Central" #47

Closed remcowesterhoud closed 1 year ago

remcowesterhoud commented 1 year ago

This reverts commit 91a3ff5c45055a189d6966de42dad547b4da034c.

These changes were supposed to fix an unintended double deployment. This is not what they do. Instead it breaks releases as the removed profile added some plugins that are required for a release to maven central.

berndruecker commented 1 year ago

Ok - I trigger a new release

berndruecker commented 1 year ago

@remcowesterhoud I simply deleted the v14 release - that should also do the trick to go back - or WDYT?

remcowesterhoud commented 1 year ago

@berndruecker That works if nobody updated to this version yet. If they did then their pipeline will be unable to find that specific version all of a sudden.

berndruecker commented 1 year ago

I think that risk is pretty small - also the BP is no to use a specific version of the action anyway I think - or would you prefer to play safe and release a new version?

remcowesterhoud commented 1 year ago

I would assume most people use the v1 tag as that is the BP. So it's fine with me like this.