search

camunda-community-hub / pyzeebe

Python client for Zeebe workflow engine
https://camunda-community-hub.github.io/pyzeebe/
MIT License
87 stars 37 forks source link

fix: bad audience in camunda cloud channel factory, clean parameters in camunda cloud channel factory #511

Closed dimastbk closed 1 month ago

dimastbk commented 1 month ago

fix #510

I suggest allowing only the required options to be set, like in the Java SDK image

ping @felicijus

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 11277692278

Details

Totals Coverage Status
Change from base Build 11277676454: 0.005%
Covered Lines: 1104
Relevant Lines: 1139
💛 - Coveralls
felicijus commented 1 month ago

If i remember correctly Spring Boot SDK for Zeebe sets these parameters by default too. @dimastbk

dimastbk commented 1 month ago

Spring Boot SDK calculates audience, scope isn't required by Camunda Cloud and oauth url is static

dimastbk commented 1 month ago

I tested this changes with Camunda SaaS

felicijus commented 1 month ago

Can I check myself tomorrow, currently i only got my phone?

felicijus commented 1 month ago
  1. audience should be static Camunda Docs audience="zeebe.camunda.io
  2. scope should either be None (Optional parameter), because setting it to the cluster_id also works. Maybe relevant for enterprise user with custom scope configs...
  3. leeway and expire_in i don't really know if there is need for customization. Would not hurt to keep I guess.

510 Is an import error, where the old create_camunda_cloud_channel function was used. (The old function also needs a static audience)

Do we want to close this pull-request then and I will provide a fix for the scope issue ?