camunda-community-hub / zeebe-client-csharp

Contains an Zeebe C# client implementation.
https://camunda-community-hub.github.io/zeebe-client-csharp/
Apache License 2.0
98 stars 53 forks source link

C# client should understand/use the same token format as other clients #114

Closed Zelldon closed 3 years ago

Zelldon commented 4 years ago

Currently the C# client stores the token differently then the Java or Go client, this should be adjusted to the same format so it can use the same cached token.

Zelldon commented 4 years ago

Take a look at the latest updates:

https://github.com/zeebe-io/zeebe/pull/4115/files#diff-5e07f5c0f5a2d048db781022d372e18a

Zelldon commented 4 years ago

https://github.com/aaubry/YamlDotNet

Zelldon commented 3 years ago

I will not do that right now, because it will introduce another dependency which doesn't make sense to me.

In Java and Go we get the JSON response form the AUTH endpoint and convert that into yaml to store it. On reading we convert that into a object and use that for the oauth. Idk why we need two serialization formats here :shrug: I will keep the JSON format and store it still under ~/.zeebe but into a new file called credentials.

Furthermore I will fix https://github.com/camunda-community-hub/zeebe-client-csharp/issues/146