camunda-community-hub / zeebe-client-csharp

Contains an Zeebe C# client implementation.
https://camunda-community-hub.github.io/zeebe-client-csharp/
Apache License 2.0
98 stars 53 forks source link

Response Variables property is not very convenient #214

Closed xlegalles closed 3 years ago

xlegalles commented 3 years ago

The response Variablesproperty is a string and this is not very convenient: the proof is the addition of a getVariablesAsMap method in the java client.

The solution would be to add the same kind of facilities in the C# client: GetVariablesAsMapand GetVariablesAsType(names are the same as the java ones) that return respectively an IReadOnlyDictionary<string, object> and T.

Remaining questions are:

I can make a PR if you agree.

Thank you

Zelldon commented 3 years ago

I will close this, since after discussion we also closed the related PR :) https://github.com/camunda-community-hub/zeebe-client-csharp/pull/220 feel free to reopen it if you disagree.