search

camunda-community-hub / zeebe-client-node-js

Node.js client library for Zeebe Microservices Orchestration Engine
https://camunda-community-hub.github.io/zeebe-client-node-js/
Apache License 2.0
152 stars 38 forks source link

User agent is not set in client requests #225

Closed Zelldon closed 3 years ago

Zelldon commented 3 years ago

We can see that we set it here:

https://github.com/camunda-community-hub/zeebe-client-node-js/blob/953a93894406d6e55cdfcc1e6289599644f77831/src/lib/OAuthProvider.ts#L101

But is it maybe a problem that we use ` instead of ' ? @jwulf

Zelldon commented 3 years ago

Ok as you can see I'm a total typescript noob :) TIL https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals

Zelldon commented 3 years ago

But still it is not sent, as we yesterday discussed

Zelldon commented 3 years ago

Ok I think I know why.

In the current node-js client impl it looks like we only set it if we get the token? But not always on the grpc lib, as we do in other clients. Example in the c# client https://github.com/camunda-community-hub/zeebe-client-csharp/blob/master/Client/ZeebeClient.cs#L62 we set it here as channel options.

Java client https://github.com/camunda-cloud/zeebe/blob/develop/clients/java/src/main/java/io/camunda/zeebe/client/impl/ZeebeClientImpl.java#L128