search

camunda-community-hub / zeebe-client-node-js

Node.js client library for Zeebe Microservices Orchestration Engine
https://camunda-community-hub.github.io/zeebe-client-node-js/
Apache License 2.0
152 stars 38 forks source link

fix: pin `@grpc` dependencies to stable version #291

Closed nikku closed 1 year ago

nikku commented 1 year ago

Related to https://github.com/camunda-community-hub/zeebe-client-node-js/issues/288 Related to https://github.com/barmac/zeebe-tls-connection-test/issues/1

Closes https://github.com/camunda-community-hub/zeebe-client-node-js/issues/290

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

nikku commented 1 year ago

Do we do actual integration tests against Zeebe self-managed? If so we could consider to execute these continuously to figure if future dependency upgrade break the system again.

jwulf commented 1 year ago

Do we do actual integration tests against Zeebe self-managed? If so we could consider to execute these continuously to figure if future dependency upgrade break the system again.

I have a test that runs locally before commit against a local insecure broker. Then there is a CI test against an insecure broker.

Let's pin the deps so that they don't move unpredictably.

nikku commented 1 year ago

We have built a test bed including CI workflow to verify zeebe-node interaction with a secured server. Maybe that is worth incorporating here.

jwulf commented 1 year ago

Thanks for this. I pinned them to a later version.