search

camunda / bpmnlint-plugin-camunda-compat

A bpmnlint plug-in for Camunda BPMN compatibility.
MIT License
0 stars 2 forks source link

Allow signal boundary events, signal catch events, signal start events in subprocess #135

Closed smbea closed 1 year ago

smbea commented 1 year ago

Related to https://github.com/camunda/camunda-modeler/issues/3819

smbea commented 1 year ago

In the light of camunda/camunda-modeler#3819 (comment), there's no need for signal-catch-with-incoming-event-gateway rule. Camunda 8.3 will allow any signal catch events.

I completely missed that 🤦‍♀️ I'll rework this

barmac commented 1 year ago

I've added a missing test case for Event Subprocess, but the CI is failing now: https://github.com/camunda/bpmnlint-plugin-camunda-compat/pull/135/commits/e594d9508205ae2c6e58d79c3b8a8ef16c18ee7a

smbea commented 1 year ago

That test is testing the no-signal-event-sub-process rule against 8.3. But in reality, that rule is not included for 8.3: https://github.com/camunda/bpmnlint-plugin-camunda-compat/pull/135/files#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346R58. And that aspect is already tested: https://github.com/camunda/bpmnlint-plugin-camunda-compat/pull/135/files#diff-c0edd0e1987ebf4144374c735ff8166e5624a9eebe543aa6bae70659a5db86feL220

smbea commented 1 year ago

@barmac do you agree we can drop that test?