Lint User Task Forms for Desktop and Web Modeler

camunda / bpmnlint-plugin-camunda-compat

A bpmnlint plug-in for Camunda BPMN compatibility.

MIT License

0 stars 2 forks source link

Lint User Task Forms for Desktop and Web Modeler #149

Closed philippfromme closed 9 months ago

philippfromme commented 9 months ago

start event with formKey or formId is allowed only by Camunda 8.3 and newer (regardless of modeler)
user task with formKey is allowed is allowed by all Camunda 8 versions (regardless of modeler)
user task with formId is allowed
- only by Camunda 8.4 (desktop modeler)
- by all versions of Camunda 8 (web modeler)

This is due to the fact that web modeler will embed linked forms (using formKey instead of formId) when deploying to Camunda 8.2 and older.

Closes https://github.com/camunda/bpmnlint-plugin-camunda-compat/issues/147 Related to https://github.com/camunda/linting/pull/92

nikku commented 9 months ago

This is due to the fact that web modeler will embed linked forms (using formKey instead of formId) when deploying to Camunda 8.2 and older.

Could you provide additional context? Why do we need to do the switch between web and desktop? Would the web mdoeler <= 8.2 way not work in Desktop, too?

philippfromme commented 9 months ago

This is due to the fact that web modeler will embed linked forms (using formKey instead of formId) when deploying to Camunda 8.2 and older.

Could you provide additional context? Why do we need to do the switch between web and desktop? Would the web mdoeler <= 8.2 way not work in Desktop, too?

The embedding happens in the web modeler, not in the engine. Therefore, deploying linked forms from the desktop modeler would only work for versions of the engine that actually support it. Can you confirm @wollefitz?

wollefitz commented 9 months ago

The embedding happens in the web modeler, not in the engine. Therefore, deploying linked forms from the desktop modeler would only work for versions of the engine that actually support it. Can you confirm @wollefitz?

Can confirm. See also the issue description of https://github.com/camunda/bpmnlint-plugin-camunda-compat/issues/147:

For Web Modeler, we'll implement a mechanism where linked forms will automatically be converted to embedded forms when deploying to a cluster version lower than 8.4 (see https://github.com/camunda/web-modeler/issues/6603 and https://github.com/camunda/web-modeler/issues/6723). Displaying a lint error to the user in this case would be confusing as it could create the impression that deploying a BPMN diagram with linked forms to Zeebe < 8.4 would not work.

In Desktop Modeler, the lint rule for checking linked forms (implemented in https://github.com/camunda/bpmnlint-plugin-camunda-compat/issues/144) should still throw an error though as no automatic conversion mechanism exists.

philippfromme commented 9 months ago

This is ready to be reviewed. 👀