camunda / bpmnlint-plugin-camunda-compat

A bpmnlint plug-in for Camunda BPMN compatibility.
MIT License
0 stars 2 forks source link

fix(timer): report not allowed error if time property not allowed #99

Closed philippfromme closed 1 year ago

philippfromme commented 1 year ago

Required by https://github.com/camunda/linting/pull/58 Related to https://github.com/camunda/camunda-modeler/issues/3653

nikku commented 1 year ago

What would be helpful is a little bit of description what is happening. From what I see we now actually validate the unsupported property, and indicate the property itself is not OK, rather than indicating the property parent being invalid. I think that is a good change.

philippfromme commented 1 year ago

What would be helpful is a little bit of description what is happening.

The difference is we don't tell you what properties you don't have that would be allowed but instead we tell you what property you do have that is not allowed. https://github.com/camunda/linting/pull/58 shows the result of that change which is a more helpful error message.