BPMN model instances are stored in database with default platform encoding

camunda / camunda-bpm-platform

Flexible framework for workflow and decision automation with BPMN and DMN. Integration with Quarkus, Spring, Spring Boot, CDI.

https://camunda.com/

Apache License 2.0

4.08k stars 1.54k forks source link

BPMN model instances are stored in database with default platform encoding #2113

Open ThorbenLindhauer opened 8 years ago

ThorbenLindhauer commented 8 years ago

This issue was imported from JIRA:

Field	Value
JIRA Link	CAM-4787
Reporter	@ThorbenLindhauer
Has restricted visibility comments	false

Should use the engine's default charset instead (confer org.camunda.bpm.engine.impl.repository.DeploymentBuilderImpl.addString(String, String) and org.camunda.bpm.engine.impl.cfg.ProcessEngineConfigurationImpl.defaultCharset)

Impact: Models may be unparseable on machines that do not have this charset.

Links:

duplicates https://jira.camunda.com/browse/CAM-6691

ThorbenLindhauer commented 8 years ago

This comment was imported from JIRA and written by user zZ6Eda

What is this name?

This pseudonym name was generated based on the user name in JIRA to protect the personal data of our JIRA users. You can use this identifier to search for issues by the same reporter.

Does this have a "backwards-compatibility dimension"?

ThorbenLindhauer commented 8 years ago

This comment was imported from JIRA and written by user @ThorbenLindhauer

Duplicate checking might not work the first time you deploy a model that way, depending on the characters and encodings used. I assume the BPMN parser would be fine with that due to XML's encoding header. I would rather expect parser exceptions when the actual encoding does not match the declared one as it may be the case now. In that sense, it might be better to ask the model API to provide a correctly encoded byte stream instead of a String.