camunda / camunda-bpm-platform

Flexible framework for workflow and decision automation with BPMN and DMN. Integration with Quarkus, Spring, Spring Boot, CDI.
https://camunda.com/
Apache License 2.0
4.11k stars 1.55k forks source link

In Cockpit, adminGroups users cannot see process instances that belong to a tenant #3020

Closed yanavasileva closed 1 year ago

yanavasileva commented 1 year ago

Environment (Required on creation)

Any setup, 7.10+

Description (Required on creation; please attach any relevant screenshots, stacktraces, log files, etc. to the ticket)

adminGroups users do not have permission to see process instances that belong to a tenant. Only camunda-admin users can access all tenants.

Steps to reproduce (Required on creation)

  1. Add MyAdminGroup to adminGroups via process engine configuration
  2. Create CamundaAdmin, member of camunda-admin group, MyAdmin member of MyAdminGroup group.
  3. Start process instance 1 that belongs to tenant1, Process-instance-2 is belongs to tenant2.
  4. Login in Cockpit with MyAdmin and navigate to the process definition where the above process instances belong.

Observed Behavior (Required on creation)

MyAdmin cannot see process instance 1 and process instance 2. CamundaAdmin can see them.

Expected behavior (Required on creation)

MyAdmin can access the process instances that belong to a tenant.

Root Cause (Required on prioritization)

In webapps, tenant check is excluded only for camunda-admin users and does not consider adminGroups - code

Solution Ideas

Hints

Links

Breakdown

Dev2QA handover

ThorbenLindhauer commented 1 year ago

The same problem exists with the adminUsers property of the engine configuration and should be fixed with this ticket, too.

tasso94 commented 1 year ago

@mboskamp, can you please review this? We want to include the patches on Monday, so we should probably get it through / have it merged in the next two days.

mboskamp commented 1 year ago

I will start with the review today. If I can not finish it today it's first on my list for tomorrow. 👍

tasso94 commented 1 year ago

Thank you!