Process Definition XML endpoint returns wrong HTTP code

[mboskamp]

Environment (Required on creation)

Any Camunda version

Description (Required on creation; please attach any relevant screenshots, stacktraces, log files, etc. to the ticket)

When calling the process-definition/{id}/xml endpoint with an id that is not valid, the documented HTTP response code is 404. Instead the REST API returns a 400.

Steps to reproduce (Required on creation)

Call process-definition/{id}/xml with an invalid id.

Observed Behavior (Required on creation)

The HTTP response code is 400.

Expected behavior (Required on creation)

The HTTP response code is 404.

Root Cause (Required on prioritization)

https://github.com/camunda/camunda-bpm-platform/blob/1d94a5bfe7851e81ba6d10b2c006b3dc3acedeb5/engine-rest/engine-rest/src/main/java/org/camunda/bpm/engine/rest/sub/repository/impl/ProcessDefinitionResourceImpl.java#L267

Solution Ideas

Hints

This should be documented in the REST API and probably also mentioned in the migration guide.

Links

Related to https://jira.camunda.com/browse/SUPPORT-15646

Breakdown

Dev2QA handover

• [ ] Does this ticket need a QA test and the testing goals are not clear from the description? Add a Dev2QA handover comment

[mboskamp]

@ThorbenLindhauer, assigned to you for prioritization

[ThorbenLindhauer]

The CI failures are OOM exceptions in wls-compatibility. I don't have time to rootcause them, but I'm fairly certain they are not caused by the changes.

[tmetzke]

Review complete, let's wait for code unfreeze to merge this 👍 🙂