camunda / camunda-bpm-platform

Flexible framework for workflow and decision automation with BPMN and DMN. Integration with Quarkus, Spring, Spring Boot, CDI.
https://camunda.com/
Apache License 2.0
4.11k stars 1.55k forks source link

Remove `org.jboss.as.web` dependency from WildFly distribution #3232

Closed tmetzke closed 1 year ago

tmetzke commented 1 year ago

Acceptance Criteria (Required on creation)

Hints

I'm sorry to intrude on your issue like this, but it is very much on topic and I thought it was the easiest way to contact the relevant people.

We have been using your WildFly modules for some time and are currently migrating to WildFly 27. In the process of creating a streamlined WildFly server we used Galleon to only include the relevant modules and configurations in our distribution. This led to the org.jboss.as.web module not being included anymore. The camunda-wildfly-subsystem module lists org.jboss.as.web as a dependency, which led to a deployment error.

Thus I asked the WildFly developers and maintainers about the module, and Brian Stansberry (WildFly Project Lead at Red Hat) informed me that "[...] org.jboss.as.web are not relevant to a standalone server. Those modules were used to provide older extensions that integrated HornetQ and JBoss Web respectively, not the ActiveMQ Artemis and Undertow that WildFly uses."

Therefore, I would humbly like to ask you to try to move away from this dependency when implementing WildFly 27 support.

Thank you very much in advance!

Links

Breakdown

Dev2QA handover

tmetzke commented 1 year ago

@mkomko, I tested this manually a bit on our end with the new WildFly 27 distribution. As far as I can see, we can simply remove the org.jboss.as.web module dependency from the Camunda WildFly Subsystem module. We only require the org.jboss.as.web-common module that is also used by the undertow extension, for example. So I assume this is fine to use still.

Maybe you can experiment locally and answer the following questions:

Thanks for assisting with this!

Best, Tobias

mkomko commented 1 year ago

@tmetzke Thank you for your efforts! To answer your questions:

Thanks, Manuel

tmetzke commented 1 year ago

Thanks a lot for the swift feedback, @mkomko! That confirms everything we have tested so far in https://github.com/camunda/camunda-bpm-platform/pull/3235. I will then go ahead and include this change in our WildFly 27 update 👍