Update Wildfly distro to Wildfly 29

Acceptance Criteria (Required on creation)

Wildfly distro is updated to Wildfly 29
Wildfly subsystem is updated so it works with the latest Wildfly/JBoss dependencies. Compilation errors are fixed.
Wildfly subsystem remains compatible with Wildfly 27/28/29.
- See https://github.com/camunda/camunda-bpm-platform/issues/3586

Hints

Wildfly 29 ~final is not released yet, we can start with Beta1 and update during the next weeks.~ has been released July 21st.
- https://mvnrepository.com/artifact/org.wildfly/wildfly-dist
- https://www.wildfly.org/news/2023/05/11/WildFly-Roadmap/
See https://github.com/camunda/camunda-bpm-platform/pull/3573
- PR only fixes Wildfly 28 compilation errors and is still not complete. Server starts up and engine, engine-rest, webapps, invoice example works.
- Issues: QA fails, there is a warning displayed during server startup.
- Possible causes: I replaced a few addDependency calls with requires() but left the Injector usages in the service.
Compilation errors
- ExtensionContext.registerSubsystem signature change
- Use ModelVersion.create()
- AttributeDefinition.getAttributeMarshaller has been removed
- Use getMarshaller()
- ObjectTypeAttributeDefinition.addValueTypeDescription signature change
- Add the missing argument.
- One version of ServiceBuilder.addDependency() is removed
- Use requires() instead and use the returned Supplier instead of Injectors in the service. This requires a little change as these suppliers need to be passed to the service.
- AttributeDefinition.isAllowNull removed
- Use isRequired() or isNillable().
- ⚠️isNillable is not available for Wildfly 27. Subsystem has to be compatible with 27 too.
- This class is only used for the plugin attribute and the Builder's optional parameter is always true, so we could get rid of this method call.
  - The class also looks like it was a workaround for older versions. We could potentially drop it.
- AbstractServiceListener class removed.
- Use LifecycleListener instead
- It has fewer states and CANCELLED is missing. Shouldn't be a problem, we still know if it's UP or FAILED, otherwise it could be considered cancelled.

Breakdown

### Tasks
- [ ] #3674
- [ ] https://github.com/camunda/camunda-bpm-platform/pull/3774

Current state

Errors:

[x] On start up

IllegalStateException in java.lang.IllegalStateException

``` 12:40:38,510 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-5) MSC000001: Failed to start service org.camunda.bpm.platform.process-engine.default: org.jboss.msc.service.StartException in service org.camunda.bpm.platform.process-engine.default: Failed to start service at org.jboss.msc@1.5.1.Final//org.jboss.msc.service.ServiceControllerImpl$StartTask.execute(ServiceControllerImpl.java:1609) at org.jboss.msc@1.5.1.Final//org.jboss.msc.service.ServiceControllerImpl$ControllerTask.run(ServiceControllerImpl.java:1438) at org.jboss.threads@2.4.0.Final//org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35) at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1990) at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1486) at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1363) at java.base/java.lang.Thread.run(Thread.java:834) Caused by: java.lang.IllegalStateException at org.jboss.msc@1.5.1.Final//org.jboss.msc.value.InjectedValue.getValue(InjectedValue.java:49) at org.camunda.bpm.wildfly.camunda-wildfly-subsystem@7.20.0-SNAPSHOT//org.camunda.bpm.container.impl.jboss.service.MscManagedProcessEngineController.start(MscManagedProcessEngineController.java:94) at org.jboss.msc@1.5.1.Final//org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1617) at org.jboss.msc@1.5.1.Final//org.jboss.msc.service.ServiceControllerImpl$StartTask.execute(ServiceControllerImpl.java:1580) ... 6 more ```

NullPointerException in ProcessApplicationDeploymentProcessor

``` 12:40:39,526 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-6) MSC000001: Failed to start service jboss.deployment.unit."camunda-example-invoice-jakarta-7.20.0-SNAPSHOT.war".INSTALL: org.jboss.msc.service.StartException in service jboss.deployment.unit."camunda-example-invoice-jakarta-7.20.0-SNAPSHOT.war".INSTALL: WFLYSRV0153: Failed to process phase INSTALL of deployment "camunda-example-invoice-jakarta-7.20.0-SNAPSHOT.war" at org.jboss.as.server@21.1.0.Final//org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:189) at org.jboss.msc@1.5.1.Final//org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1617) at org.jboss.msc@1.5.1.Final//org.jboss.msc.service.ServiceControllerImpl$StartTask.execute(ServiceControllerImpl.java:1580) at org.jboss.msc@1.5.1.Final//org.jboss.msc.service.ServiceControllerImpl$ControllerTask.run(ServiceControllerImpl.java:1438) at org.jboss.threads@2.4.0.Final//org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35) at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1990) at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1486) at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1377) at java.base/java.lang.Thread.run(Thread.java:834) Caused by: java.lang.NullPointerException: Method parameter cannot be null at org.jboss.msc@1.5.1.Final//org.jboss.msc.service.ServiceBuilderImpl.assertNotNull(ServiceBuilderImpl.java:364) at org.jboss.msc@1.5.1.Final//org.jboss.msc.service.ServiceBuilderImpl.requires(ServiceBuilderImpl.java:104) at org.camunda.bpm.wildfly.camunda-wildfly-subsystem@7.20.0-SNAPSHOT//org.camunda.bpm.container.impl.jboss.deployment.processor.ProcessApplicationDeploymentProcessor.deploy(ProcessApplicationDeploymentProcessor.java:183) at org.jboss.as.server@21.1.0.Final//org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:182) ... 8 more ```

[x] In engine tests - gone after resolving above

NullPointerException during add deployment (might be related to above)

``` 2023-09-13 11:55:45,290 ERROR [org.jboss.as.controller.management-operation] (management-handler-thread - 1) WFLYCTL0013: Operation ("add") failed - address: ([("deployment" => "test.war")]): java.lang.NullPointerException: Cannot invoke "org.jboss.msc.service.ServiceName.getCanonicalName()" because the return value of "org.jboss.msc.service.ServiceController.getName()" is null at org.jboss.as.controller@21.1.0.Final//org.jboss.as.controller.ServiceVerificationHelper.execute(ServiceVerificationHelper.java:112) at org.jboss.as.controller@21.1.0.Final//org.jboss.as.controller.AbstractOperationContext.executeStep(AbstractOperationContext.java:1064) at org.jboss.as.controller@21.1.0.Final//org.jboss.as.controller.AbstractOperationContext.processStages(AbstractOperationContext.java:785) at org.jboss.as.controller@21.1.0.Final//org.jboss.as.controller.AbstractOperationContext.executeOperation(AbstractOperationContext.java:476) at org.jboss.as.controller@21.1.0.Final//org.jboss.as.controller.OperationContextImpl.executeOperation(OperationContextImpl.java:1455) at org.jboss.as.controller@21.1.0.Final//org.jboss.as.controller.ModelControllerImpl.internalExecute(ModelControllerImpl.java:449) at org.jboss.as.controller@21.1.0.Final//org.jboss.as.controller.ModelControllerImpl.lambda$executeForResponse$0(ModelControllerImpl.java:259) at org.wildfly.security.elytron-base@2.2.1.Final//org.wildfly.security.auth.server.SecurityIdentity.runAs(SecurityIdentity.java:304) at org.wildfly.security.elytron-base@2.2.1.Final//org.wildfly.security.auth.server.SecurityIdentity.runAs(SecurityIdentity.java:270) at org.jboss.as.controller@21.1.0.Final//org.jboss.as.controller.ModelControllerImpl.executeForResponse(ModelControllerImpl.java:259) at org.jboss.as.controller@21.1.0.Final//org.jboss.as.controller.ModelControllerImpl.executeOperation(ModelControllerImpl.java:253) at org.jboss.as.controller@21.1.0.Final//org.jboss.as.controller.ModelControllerImpl.execute(ModelControllerImpl.java:236) at org.jboss.as.controller@21.1.0.Final//org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler.doExecute(ModelControllerClientOperationHandler.java:241) at org.jboss.as.controller@21.1.0.Final//org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler$1$1.run(ModelControllerClientOperationHandler.java:163) at org.jboss.as.controller@21.1.0.Final//org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler$1$1.run(ModelControllerClientOperationHandler.java:159) at org.wildfly.security.elytron-base@2.2.1.Final//org.wildfly.security.auth.server.SecurityIdentity.runAs(SecurityIdentity.java:328) at org.wildfly.security.elytron-base@2.2.1.Final//org.wildfly.security.auth.server.SecurityIdentity.runAs(SecurityIdentity.java:285) at org.jboss.as.controller@21.1.0.Final//org.jboss.as.controller.AccessAuditContext.doAs(AccessAuditContext.java:254) at org.jboss.as.controller@21.1.0.Final//org.jboss.as.controller.AccessAuditContext.doAs(AccessAuditContext.java:225) at org.jboss.as.controller@21.1.0.Final//org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler$1.execute(ModelControllerClientOperationHandler.java:159) at org.jboss.as.protocol@21.1.0.Final//org.jboss.as.protocol.mgmt.ManagementRequestContextImpl$1.doExecute(ManagementRequestContextImpl.java:70) at org.jboss.as.protocol@21.1.0.Final//org.jboss.as.protocol.mgmt.ManagementRequestContextImpl$AsyncTaskRunner.run(ManagementRequestContextImpl.java:160) at org.jboss.threads@2.4.0.Final//org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35) at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1990) at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1486) at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1377) at java.base/java.lang.Thread.run(Thread.java:833) at org.jboss.threads@2.4.0.Final//org.jboss.threads.JBossThread.run(JBossThread.java:513) ```

TODOs

[ ] #isNillable() is not available in WFLY27, #isAllowNull() not available in WFLY28 - link

Findings (notes)

In a few places the InjectedValue has been replaced by Supplier and also serviceBuilder.addDependency() replaced by serviceBuilder.requires() (link to commit). It seems the first exception related to the change.

Current state

:green_circle: the CI is green for Wildfly 29 :green_circle: the server with the webapps starts successfully as well 🟡 warning thrown on server stop :red_circle: the backwards compatibility for WildFly 27 is broken at the moment

Warning output on WildFly 29 server stop

``` 09:20:44,613 WARNING [org.camunda.bpm.container.impl.jboss.service.ProcessApplicationStopService] (MSC service thread 1-2) Exception while invoking BpmPlatformPlugin.postProcessApplicationUndeploy: java.lang.NullPointerException at org.camunda.bpm.wildfly.camunda-wildfly-subsystem@7.20.0-SNAPSHOT//org.camunda.bpm.container.impl.jboss.service.ProcessApplicationStopService.stop(ProcessApplicationStopService.java:81) at org.jboss.msc@1.5.1.Final//org.jboss.msc.service.ServiceControllerImpl$StopTask.stopService(ServiceControllerImpl.java:1671) at org.jboss.msc@1.5.1.Final//org.jboss.msc.service.ServiceControllerImpl$StopTask.execute(ServiceControllerImpl.java:1641) at org.jboss.msc@1.5.1.Final//org.jboss.msc.service.ServiceControllerImpl$ControllerTask.run(ServiceControllerImpl.java:1438) at org.jboss.threads@2.4.0.Final//org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35) at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1990) at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1486) at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1377) at java.base/java.lang.Thread.run(Thread.java:834) ```

Error on WildFly 27

``` 09:01:39,550 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-5) MSC000001: Failed to start service jboss.deployment.unit."camunda-example-invoice-jakarta-7.20.0-SNAPSHOT.war".INSTALL: org.jboss.msc.service.StartException in service jboss.deployment.unit."camunda-example-invoice-jakarta-7.20.0-SNAPSHOT.war".INSTALL: WFLYSRV0153: Failed to process phase INSTALL of deployment "camunda-example-invoice-jakarta-7.20.0-SNAPSHOT.war" at org.jboss.as.server@19.0.1.Final//org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:189) at org.jboss.msc@1.4.13.Final//org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1739) at org.jboss.msc@1.4.13.Final//org.jboss.msc.service.ServiceControllerImpl$StartTask.execute(ServiceControllerImpl.java:1701) at org.jboss.msc@1.4.13.Final//org.jboss.msc.service.ServiceControllerImpl$ControllerTask.run(ServiceControllerImpl.java:1559) at org.jboss.threads@2.4.0.Final//org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35) at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1990) at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1486) at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1377) at java.base/java.lang.Thread.run(Thread.java:834) Caused by: java.lang.NoSuchMethodError: org.jboss.msc.service.ServiceTarget.addService()Lorg/jboss/msc/service/ServiceBuilder; at org.camunda.bpm.wildfly.camunda-wildfly-subsystem@7.20.0-SNAPSHOT//org.camunda.bpm.container.impl.jboss.deployment.processor.ProcessApplicationDeploymentProcessor.deploy(ProcessApplicationDeploymentProcessor.java:102) at org.jboss.as.server@19.0.1.Final//org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:182) ... 8 more 09:01:39,555 ERROR [org.jboss.as.controller.management-operation] (DeploymentScanner-threads - 1) WFLYCTL0013: Operation ("deploy") failed - address: ([("deployment" => "camunda-example-invoice-jakarta-7.20.0-SNAPSHOT.war")]) - failure description: {"WFLYCTL0080: Failed services" => {"jboss.deployment.unit.\"camunda-example-invoice-jakarta-7.20.0-SNAPSHOT.war\".INSTALL" => "WFLYSRV0153: Failed to process phase INSTALL of deployment \"camunda-example-invoice-jakarta-7.20.0-SNAPSHOT.war\" Caused by: java.lang.NoSuchMethodError: org.jboss.msc.service.ServiceTarget.addService()Lorg/jboss/msc/service/ServiceBuilder;"}} ```

Notes to keep backwards compatibility

ServiceTarget#addService() is not available in WildFly 27 - try to use ServiceTarget#addService(ServiceName)

Outcome by the end of the day

🟢 WildFly 29: CI still green after the changes
🟢 WildFly 27: tested locally and it looks fine
⚪ remaining the todo for #isNillable() - I was not able to confirm if we can remove the FixedObjectTypeAttributeDefinition class

Today's notes

[x] #isNillable()

My initial idea was to remove the FixedObjectTypeAttributeDefinition class and leave the ReflectionCompatibilityTest to test it with ObjectTypeAttributeDefinition. (For reference: the logic was introduced in CAM-5737.) However, the used methods are not public so it's not possible to achieve this out-of-the-box. Therefore I run locally the test with the default implementation and it passed successfully.

pros: simplify logic that is not necessary anymore and use default jboss logic
cons: potentially can break in future releases as we don't have test coverage

Alternative: hard code true value, the value we set that value during the initialization in org.camunda.bpm.container.impl.jboss.extension.SubsystemAttributeDefinitons.PLUGIN

pros: leave the current logic and test
cons: doesn't seem we need it anymore and hard coding a value can change/break logic in future versions

Decision: Remove the class and the test (incl. test resources).

Still open

warning on server stop in WildFly 27/29 - java.lang.IllegalStateException: Process application 'InvoiceProcessApplication' is not unavailable. - 🔴 no idea yet

Stacktrace

``` 2023-09-15 10:35:22,801 WARNING [org.camunda.bpm.container.impl.jboss.service.ProcessApplicationStopService] (MSC service thread 1-6) Exception while invoking BpmPlatformPlugin.postProcessApplicationUndeploy: java.lang.IllegalStateException: Process application 'InvoiceProcessApplication' is not unavailable. at org.camunda.bpm.wildfly.camunda-wildfly-subsystem@7.20.0-SNAPSHOT//org.camunda.bpm.container.impl.jboss.service.NoViewProcessApplicationStartService.getValue(NoViewProcessApplicationStartService.java:48) at org.camunda.bpm.wildfly.camunda-wildfly-subsystem@7.20.0-SNAPSHOT//org.camunda.bpm.container.impl.jboss.service.NoViewProcessApplicationStartService.getValue(NoViewProcessApplicationStartService.java:35) at org.jboss.msc@1.4.13.Final//org.jboss.msc.service.ServiceControllerImpl.getValue(ServiceControllerImpl.java:1109) at org.jboss.msc@1.4.13.Final//org.jboss.msc.service.ServiceRegistrationImpl.getValue(ServiceRegistrationImpl.java:163) at org.jboss.msc@1.4.13.Final//org.jboss.msc.service.ReadableValueImpl.get(ReadableValueImpl.java:40) at org.camunda.bpm.wildfly.camunda-wildfly-subsystem@7.20.0-SNAPSHOT//org.camunda.bpm.container.impl.jboss.service.ProcessApplicationStopService.stop(ProcessApplicationStopService.java:87) at org.jboss.msc@1.4.13.Final//org.jboss.msc.service.ServiceControllerImpl$StopTask.stopService(ServiceControllerImpl.java:1795) at org.jboss.msc@1.4.13.Final//org.jboss.msc.service.ServiceControllerImpl$StopTask.execute(ServiceControllerImpl.java:1764) at org.jboss.msc@1.4.13.Final//org.jboss.msc.service.ServiceControllerImpl$ControllerTask.run(ServiceControllerImpl.java:1559) at org.jboss.threads@2.4.0.Final//org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35) at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1990) at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1486) at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1377) at java.base/java.lang.Thread.run(Thread.java:834) Caused by: org.camunda.bpm.application.ProcessApplicationUnavailableException: ENGINE-07011 Process Application 'InvoiceProcessApplication' unavailable at org.camunda.bpm.camunda-engine@7.20.0-SNAPSHOT//org.camunda.bpm.application.impl.ProcessApplicationLogger.processApplicationUnavailableException(ProcessApplicationLogger.java:114) at org.camunda.bpm.camunda-engine@7.20.0-SNAPSHOT//org.camunda.bpm.application.impl.ProcessApplicationReferenceImpl.getProcessApplication(ProcessApplicationReferenceImpl.java:65) at org.camunda.bpm.camunda-engine@7.20.0-SNAPSHOT//org.camunda.bpm.application.impl.ProcessApplicationReferenceImpl.getProcessApplication(ProcessApplicationReferenceImpl.java:44) at org.camunda.bpm.wildfly.camunda-wildfly-subsystem@7.20.0-SNAPSHOT//org.camunda.bpm.container.impl.jboss.service.NoViewProcessApplicationStartService.getValue(NoViewProcessApplicationStartService.java:45) ... 13 more ```

[x] warning on server stop in WildFly 27/29 - java.lang.IllegalStateException: Process application 'InvoiceProcessApplication' is not unavailable. - stacktrace - check the previous comment

Impact of the thrown warning:

#postProcessApplicationUndeploy() logic won't be executed for custom BpmPlatformPlugins

The warning was not thrown before as it was used a stored value from the Injector. There's no such concept for "stored" values with Suppliers.

Why the application is not available at this point (only for stop)? Code for registering the process application service: https://github.com/camunda/camunda-bpm-platform/blob/57f0a570b262659fe19440c12eb938656887aa7d/distro/wildfly/subsystem/src/main/java/org/camunda/bpm/container/impl/jboss/service/ProcessApplicationStartService.java#L173-L177 On shutdown the order is:

Stop ProcessApplicationStartService and along with MscManagedProcessApplication => the application is gone
Stop ProcessApplicationDeploymentService
Stop ProcessApplicationStopService where the warning is thrown due to process application reference not available anymore

Further: it uses the #getChildTarget() from the ProcessApplicationStartService

Get a service target which may be used to add child services. Child services have an implicit dependency on their parent, and are automatically removed when the parent service stops (or if the parent service fails during startup).

Where the order of service start/stop is defined? - dependencies/requires

Can we initialize MscManagedProcessApplication in ProcessApplicationDeploymentProcessor? - no, as we can adjust the existing dependencies of the services, it can create a cycle.

Root cause:

The process application is cleaned up in ProcessApplicationReferenceImpl#clear() during the servlet destroy that is called before the #stop() of ProcessApplicationStopService where the application is needed to executed #postProcessApplicationUndeploy()

Decision:

🟢 Add skipClear flag to ProcessApplicationReferenceImpl to ensure the process application is available when the ProcessApplicationStopService is stopped. Clear the process application reference in NoViewProcessApplicationStartService instead.

Detected warning in the tests:

WARN [org.jboss.as.arquillian] (MSC service thread 1-2) Cannot find composite annotation index in: deployment "XXX.war" - the warning appeared with the arquillian version update, not related to the WildFly 29 changes. I didn't find much details about it, I suggest to ignore it.

Further notes on warning during stop service and process application not available:

https://github.com/camunda/camunda-bpm-platform/pull/3674#discussion_r1330382510
Can we confirm somehow that an instance for each deployment of ProcessApplicationStopService exists? - During debug, I see that for each deployment, the method ProcessApplicationDeploymentProcessor#deploy is called, which creates an instance of ProcessApplicationStopService so the reference to the process application is coupled to the deployment and probably garbage collected at undeployment.

We decided to revert the made changes for #addDependencies (and the Injectors) so that we don't implement a workaround for stop service and the missing process application. Argument: the risk is higher with the workaround and we don't fully see the complete picture yet. (secondary: code will be more consistent; we can update to the new API later)

Tested locally with latest approved changes and rebase to master (with reverted PD feature):

🟢 WildFly 27 (CE/EE) with the new subsystem start/shutdown (not extensive regression testing)
🟢 ran engine IT against WildFly 27 CE with h2 db
🟢 ran webapps IT against WildFly 27 CE with h2 db

Closing as done. Feature testing will be done in the parent ticket.

Reopen to note the license change

License update:

Removed jakarta from maven coordinates - license didn't changed or already approaved


<    org.jboss.invocation:jboss-invocation-jakarta:jar:1.7.0.Final:provided:/root/.m2/repository/org/jboss/invocation/jboss-invocation-jakarta/1.7.0.Final/jboss-invocation-jakarta-1.7.0.Final.jar
<    org.jboss.ironjacamar:ironjacamar-common-api-jakarta:jar:1.5.9.Final:provided:/root/.m2/repository/org/jboss/ironjacamar/ironjacamar-common-api-jakarta/1.5.9.Final/ironjacamar-common-api-jakarta-1.5.9.Final.jar
<    org.jboss.ironjacamar:ironjacamar-common-impl-jakarta:jar:1.5.9.Final:provided:/root/.m2/repository/org/jboss/ironjacamar/ironjacamar-common-impl-jakarta/1.5.9.Final/ironjacamar-common-impl-jakarta-1.5.9.Final.jar
<    org.jboss.ironjacamar:ironjacamar-common-spi-jakarta:jar:1.5.9.Final:provided:/root/.m2/repository/org/jboss/ironjacamar/ironjacamar-common-spi-jakarta/1.5.9.Final/ironjacamar-common-spi-jakarta-1.5.9.Final.jar
<    org.jboss.ironjacamar:ironjacamar-core-api-jakarta:jar:1.5.9.Final:provided:/root/.m2/repository/org/jboss/ironjacamar/ironjacamar-core-api-jakarta/1.5.9.Final/ironjacamar-core-api-jakarta-1.5.9.Final.jar
<    org.jboss.ironjacamar:ironjacamar-core-impl-jakarta:jar:1.5.9.Final:provided:/root/.m2/repository/org/jboss/ironjacamar/ironjacamar-core-impl-jakarta/1.5.9.Final/ironjacamar-core-impl-jakarta-1.5.9.Final.jar
<    org.jboss.ironjacamar:ironjacamar-deployers-common-jakarta:jar:1.5.9.Final:provided:/root/.m2/repository/org/jboss/ironjacamar/ironjacamar-deployers-common-jakarta/1.5.9.Final/ironjacamar-deployers-common-jakarta-1.5.9.Final.jar
<    org.jboss.ironjacamar:ironjacamar-jdbc-jakarta:jar:1.5.9.Final:provided:/root/.m2/repository/org/jboss/ironjacamar/ironjacamar-jdbc-jakarta/1.5.9.Final/ironjacamar-jdbc-jakarta-1.5.9.Final.jar
<    org.jboss.ironjacamar:ironjacamar-validator-jakarta:jar:1.5.9.Final:provided:/root/.m2/repository/org/jboss/ironjacamar/ironjacamar-validator-jakarta/1.5.9.Final/ironjacamar-validator-jakarta-1.5.9.Final.jar
<    org.jboss.metadata:jboss-metadata-common-jakarta:jar:15.2.0.Final:provided:/root/.m2/repository/org/jboss/metadata/jboss-metadata-common-jakarta/15.2.0.Final/jboss-metadata-common-jakarta-15.2.0.Final.jar
<    org.jboss.narayana.jts:narayana-jts-integration-jakarta:jar:5.13.0.Final:provided:/root/.m2/repository/org/jboss/narayana/jts/narayana-jts-integration-jakarta/5.13.0.Final/narayana-jts-integration-jakarta-5.13.0.Final.jar
<    org.jboss:jboss-iiop-client-jakarta:jar:1.0.2.Final:provided:/root/.m2/repository/org/jboss/jboss-iiop-client-jakarta/1.0.2.Final/jboss-iiop-client-jakarta-1.0.2.Final.jar
<    org.jboss:jboss-transaction-spi-jakarta:jar:7.6.1.Final:provided:/root/.m2/repository/org/jboss/jboss-transaction-spi-jakarta/7.6.1.Final/jboss-transaction-spi-jakarta-7.6.1.Final.jar

org.jboss.invocation:jboss-invocation:jar:2.0.0.Final:provided:/root/.m2/repository/org/jboss/invocation/jboss-invocation/2.0.0.Final/jboss-invocation-2.0.0.Final.jar org.jboss.ironjacamar:ironjacamar-common-api:jar:3.0.3.Final:provided:/root/.m2/repository/org/jboss/ironjacamar/ironjacamar-common-api/3.0.3.Final/ironjacamar-common-api-3.0.3.Final.jar org.jboss.ironjacamar:ironjacamar-common-impl:jar:3.0.3.Final:provided:/root/.m2/repository/org/jboss/ironjacamar/ironjacamar-common-impl/3.0.3.Final/ironjacamar-common-impl-3.0.3.Final.jar org.jboss.ironjacamar:ironjacamar-common-spi:jar:3.0.3.Final:provided:/root/.m2/repository/org/jboss/ironjacamar/ironjacamar-common-spi/3.0.3.Final/ironjacamar-common-spi-3.0.3.Final.jar org.jboss.ironjacamar:ironjacamar-core-api:jar:3.0.3.Final:provided:/root/.m2/repository/org/jboss/ironjacamar/ironjacamar-core-api/3.0.3.Final/ironjacamar-core-api-3.0.3.Final.jar org.jboss.ironjacamar:ironjacamar-core-impl:jar:3.0.3.Final:provided:/root/.m2/repository/org/jboss/ironjacamar/ironjacamar-core-impl/3.0.3.Final/ironjacamar-core-impl-3.0.3.Final.jar org.jboss.ironjacamar:ironjacamar-deployers-common:jar:3.0.3.Final:provided:/root/.m2/repository/org/jboss/ironjacamar/ironjacamar-deployers-common/3.0.3.Final/ironjacamar-deployers-common-3.0.3.Final.jar org.jboss.ironjacamar:ironjacamar-jdbc:jar:3.0.3.Final:provided:/root/.m2/repository/org/jboss/ironjacamar/ironjacamar-jdbc/3.0.3.Final/ironjacamar-jdbc-3.0.3.Final.jar org.jboss.ironjacamar:ironjacamar-validator:jar:3.0.3.Final:provided:/root/.m2/repository/org/jboss/ironjacamar/ironjacamar-validator/3.0.3.Final/ironjacamar-validator-3.0.3.Final.jar org.jboss.metadata:jboss-metadata-common:jar:16.0.0.Final:provided:/root/.m2/repository/org/jboss/metadata/jboss-metadata-common/16.0.0.Final/jboss-metadata-common-16.0.0.Final.jar org.jboss.narayana.jts:narayana-jts-integration:jar:6.0.1.Final:provided:/root/.m2/repository/org/jboss/narayana/jts/narayana-jts-integration/6.0.1.Final/narayana-jts-integration-6.0.1.Final.jar org.jboss:jboss-iiop-client:jar:2.0.1.Final:provided:/root/.m2/repository/org/jboss/jboss-iiop-client/2.0.1.Final/jboss-iiop-client-2.0.1.Final.jar org.jboss:jboss-transaction-spi:jar:8.0.0.Final:provided:/root/.m2/repository/org/jboss/jboss-transaction-spi/8.0.0.Final/jboss-transaction-spi-8.0.0.Final.jar
narayana is GNU Lesser General Public License v2.1 (not part of distro and already approved in https://jira.camunda.com/browse/OB-27)

openjdk-orb license changed and it's on the stop list => clarify usage with Legal.

<    org.jboss.openjdk-orb:openjdk-orb-jakarta:jar:8.1.9.Final:provided:/root/.m2/repository/org/jboss/openjdk-orb/openjdk-orb-jakarta/8.1.9.Final/openjdk-orb-jakarta-8.1.9.Final.jar
( GNU Lesser General Public License version 2.1)
>    org.jboss.openjdk-orb:openjdk-orb:jar:9.0.2.Final:provided:/root/.m2/repository/org/jboss/openjdk-orb/openjdk-orb/9.0.2.Final/openjdk-orb-9.0.2.Final.jar
( GNU General Public License v2.0 only, with Classpath exception)

The rest is unchanged

Raised ticket for openjdk-orb: https://jira.camunda.com/browse/OB-33

We need to clarify further if this is the first case for a transitive dependency with GPL 2.0 in WildFly. For now, we will exclude the transitive dependency before building the alpha.

Closing this ticket as done, I will create a separate ticket if necessary while processing https://jira.camunda.com/browse/OB-33.

camunda / camunda-bpm-platform