camunda / camunda-bpm-platform

Flexible framework for workflow and decision automation with BPMN and DMN. Integration with Quarkus, Spring, Spring Boot, CDI.
https://camunda.com/
Apache License 2.0
4.11k stars 1.55k forks source link

Support custom pretty print configuration for Spin XML #3633

Closed tmetzke closed 1 year ago

tmetzke commented 1 year ago

User Story (Required on creation)

As an operations engineer, I can replace the default pretty-printing configuration for Spin XML with a custom configuration. This allows me to define XML attributes that are not stripped of content if they consist of whitespace characters only, for example. With that, my XMLs still get pretty printed - which is great for our users - and adhere to XML schemas that enforce that certain elements always have content, even if it is just one whitespace character, for example.

Functional Requirements (Required before implementation)

Technical Requirements (Required before implementation)

Limitations of Scope

Hints

Links

Breakdown

Dev2QA handover


### Pull Requests
-  [ ] https://github.com/camunda/camunda-spin/pull/205
- [ ] https://github.com/camunda/camunda-spin/pull/210
- [ ] https://github.com/camunda/camunda-spin/pull/209
- [ ] https://github.com/camunda/camunda-bpm-platform/pull/3675
- [ ] https://github.com/camunda/camunda-bpm-platform-maintenance/pull/1065
- [ ] https://github.com/camunda/camunda-bpm-platform-maintenance/pull/1066
mboskamp commented 1 year ago

❓ Why don't we backport this to 7.17 too?

tmetzke commented 1 year ago

❓ Why don't we backport this to 7.17 too?

Excellent question, forgot to mention it here πŸ™‚πŸ‘ We don't have pretty-print configurability at all in 7.17.x (using Spin 1.14.x). This was introduced with 7.18. Backporting this would require too much effort in Spin. Plus, the customer only needs this in 7.18. Plus, it's a feature, so we usually don't backport this at all but did it here due to customer request.

mboskamp commented 1 year ago

Alright, that makes sense. Ready for merge from my side πŸ‘