camunda / camunda-bpm-platform

Flexible framework for workflow and decision automation with BPMN and DMN. Integration with Quarkus, Spring, Spring Boot, CDI.
https://camunda.com/
Apache License 2.0
4.12k stars 1.56k forks source link

Documentation for ACT_HI_JOB_LOG doesn't show the HOSTNAME_ column #3684

Closed ingorichtsmeier closed 1 year ago

ingorichtsmeier commented 1 year ago

Environment (Required on creation)

https://docs.camunda.org/manual/7.19/user-guide/process-engine/database/database-schema/#history

Description (Required on creation; please attach any relevant screenshots, stacktraces, log files, etc. to the ticket)

The image showing the entity relationship diagram for history (https://github.com/camunda/camunda-docs-manual/blob/master/content/user-guide/process-engine/img/erd_718_history.svg) doesn't show the HOSTNAME_ column for the ACT_HI_JOB_LOG table. The column is available in the mapping.xml (https://github.com/camunda/camunda-bpm-platform/blob/master/engine/src/main/resources/org/camunda/bpm/engine/impl/mapping/entity/HistoricJobLog.xml#L49)

Expected behavior (Required on creation)

The HOSTNAME_ column of table ACT_HI_JOB_LOG is in the picture.

Root Cause (Required on prioritization)

Just a guess: the entity relation-ship diagram is not generated correctly: https://github.com/camunda/camunda-docs-manual/blob/master/content/user-guide/process-engine/erd-project/erd-bpmn_7.18.mwb

Breakdown

### Pull Requests
- [ ] https://github.com/camunda/camunda-docs-manual/pull/1543
- [ ] https://github.com/camunda/camunda-docs-manual/pull/1545

Dev2QA handover

danielkelemen commented 1 year ago

Hi @ingorichtsmeier, thank you for opening the issue!

It really looks like the ER diagram was generated without this one field, even though it's been added a long time ago (commit). I'm not sure why, other new columns appear correctly, like the ACT_HI_INCIDENT.ANNOTATION_ which was added later.

I'll try to regenerate it next week, maybe I notice something.

-Daniel

tmetzke commented 1 year ago

@danielkelemen, let's add this to 7.18 as well, shall we?

tmetzke commented 1 year ago

Side note: has been fixed in 7.20 with https://github.com/camunda/camunda-docs-manual/pull/1542