camunda / camunda-bpm-platform

Flexible framework for workflow and decision automation with BPMN and DMN. Integration with Quarkus, Spring, Spring Boot, CDI.
https://camunda.com/
Apache License 2.0
4.11k stars 1.55k forks source link

In Cockpit, on processes page, deleting process definitions by key is a no-op #3758

Closed tasso94 closed 1 year ago

tasso94 commented 1 year ago

Environment (Required on creation)

7.20.0

Description (Required on creation; please attach any relevant screenshots, stacktraces, log files, etc. to the ticket)

In Cockpit, deleting process definitions by key on the processes page is a no-op.

Steps to reproduce (Required on creation)

  1. Navigate to the processes page.
  2. Click for a process definition on the delete button.

Delete action processes page

Observed Behavior (Required on creation)

Nothing happens (no-op). The browser console shows the following error:

Browser console error ``` deps.js?bust=7.20.0-SNAPSHOT:2 Error: One of component or template or templateUrl options is required. at l.open (deps.js?bust=7.20.0-SNAPSHOT:2:827392) at e.openDialog (plugin.js?bust=7.20.0-SNAPSHOT:2:307551) at fn (eval at compile (deps.js?bust=7.20.0-SNAPSHOT:2:124633), :4:211) at r (deps.js?bust=7.20.0-SNAPSHOT:2:170515) at c.$eval (deps.js?bust=7.20.0-SNAPSHOT:2:121365) at c.$apply (deps.js?bust=7.20.0-SNAPSHOT:2:121610) at HTMLAnchorElement. (deps.js?bust=7.20.0-SNAPSHOT:2:170600) at HTMLAnchorElement.dispatch (deps.js?bust=7.20.0-SNAPSHOT:163:983324) at g.handle (deps.js?bust=7.20.0-SNAPSHOT:163:981319) ```

Expected behavior (Required on creation)

A modal dialog opens. No error is shown in the browser console.

Root Cause (Required on prioritization)

During the Webpack migration, the URL of the modal dialog template is not passed correctly anymore.

Solution Ideas

Remove .default: https://github.com/camunda/camunda-bpm-platform-ee/blob/2cbc51c01b49ed021d81298dea44130a27b1574b/webapps/camunda-webapp/plugins/frontend/plugin/cockpit/processActionsEE/app/views/processActionsEE/deleteProcessDefinitionsAction.js#L30-L31

Hints

Links

Breakdown

### Pull Requests
- [ ] https://github.com/camunda/camunda-bpm-platform-ee/pull/856

Dev2QA handover

gbetances089 commented 1 year ago

Tested on camunda-bpm-run-ee-7.20.0-20230919.164815-139

No errors on the console, candidate for an E2E test, will raise a ticket to cover it.

https://github.com/camunda/camunda-bpm-platform/assets/2312478/c0f6f21f-f67f-4b2b-bd3b-ef78943c87b6