Add REST API Test for Logging of Persistence Connection Errors - Githubissues

camunda / camunda-bpm-platform

Flexible framework for workflow and decision automation with BPMN and DMN. Integration with Quarkus, Spring, Spring Boot, CDI.

https://camunda.com/

Apache License 2.0

4.11k stars 1.55k forks source link

Add REST API Test for Logging of Persistence Connection Errors #3762

Closed psavidis closed 1 year ago

psavidis commented 1 year ago

Acceptance Criteria (Required on creation)

As a follow-up of this conversation, we need to add a test for the REST API that verifies that SQLExceptions with SQLState=08XXX (connection errors) that occur during a REST call will be logged as ERRORS.

The test should have the following structure: Given a REST API Call (e.g list groups) that performs a query to the db When a db connection error occurs Then the logging of that exception should take place using ERROR Logging level

Hints

See org.camunda.bpm.engine.rest.exception.ExceptionLogger & the handling of ProcessEnginePersistenceException

This ticket should be treated as technical debt for covering the REST API's logging of db connection problems with an automated test.
It can be developed as soon as the linked feature is merged to master

Links

https://github.com/camunda/camunda-bpm-platform/pull/3531

Breakdown

### Pull Requests
- [ ] https://github.com/camunda/camunda-bpm-platform/pull/3775

Dev2QA handover

[ ] Does this ticket need a QA test and the testing goals are not clear from the description? Add a Dev2QA handover comment

psavidis commented 1 year ago

This can be merged to master after the code-freeze for 7.20 release.

tasso94 commented 1 year ago

@psavidis, please add version labels.