Closed psavidis closed 10 months ago
@psavidis, this ticket is in progress but assigned to me. What is the status?
@psavidis, this ticket is in progress but assigned to me. What is the status?
I've corrected the status to Review. The changes are applied for all the Code Review points. We can review them further.
I have reviewed the engine
and engine-rest
changes. Let's discuss those before I move on to dependent PRs.
The Code review of the backend is done and can proceed. Also the client points have been addressed too.
The spring boot client integration can be part of the client since the changes are not numerous.
Update for the Review :
For the Spring-Boot integration of the Client, the following agreements have been made with the tech lead:
useCreateTime
& orderByCreateTime
have been configured via Spring Boot configuration, it makes sense to fail with an exception (SpringExternalTaskClientException
)asc
or desc
, the client will throw an SpringExternalTaskClientException
.
Acceptance Criteria (Required on creation)
[x] Add the capability of sorting by createTime to the Query API
[x] Adjust Persistence Layer to Sort by Create Time
[x] Add Sort by Create Time to Fetch and Lock API
[x] Add the parameter to the Fetch and Lock API of External Tasks
[x] Currently usePriority implementation defines the order statically to DESC. Change this to so that ordering can work both for ASC and DESC configuration for prioritising create-time in LIFO and FIFO orders.
[x] Implement Multi-Level Sorting By Considering Fields in the following order:
[x] Add Create Time to Open API
[x] Add the Sort by Create Time Capability to the Java Client
Hints
Links
Breakdown