Consolidate camunda-template-engines-jsr223 into Platform

venetrius commented 7 months ago

Acceptance Criteria (Required on creation)

Camunda platform contains camunda-template-engines-jsr223 with its code and git history Camunda-Spin master is updated source code removed & README.md updated

Links

parent issue: https://github.com/camunda/camunda-bpm-platform/issues/3682

Breakdown

### Pull Requests
- [ ] https://github.com/camunda/camunda-bpm-platform/pull/4355
- [ ] https://github.com/camunda/automation-platform-vulnerability-scan/pull/3183
- [ ] https://github.com/camunda/camunda-template-engines-jsr223/pull/37
- [ ] https://github.com/camunda/camunda-docs-manual/pull/1639
- [ ] https://github.com/camunda/camunda-bpm-helper-resources/pull/7
- [ ] https://github.com/camunda/camunda-bpm-platform/pull/4373

venetrius commented 5 months ago

Steps:

[x] merge repo history into platform
[x] remove unused files
[x] update README.md
[x] update POMs to build and use library with project.version
[x] use shared dependency versions (defined in pom.xml, parent/pom.xml)
[x] build locally
[x] build with CI using ci:all-as label
[x] update project repo to retire library
[x] update manual-docs
[x] update vulnerability scan

venetrius commented 5 months ago

The CLA check for platform PR did not pass.

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our [Contributor License Agreement](https://cla-assistant.io/camunda/camunda-bpm-platform?pullRequest=4355) before we can accept your contribution.
1 out of 5 committers have signed the CLA.

✅ psavidis
❌ Jenkins
❌ menski
❌ hawky-4s-
❌ skjolber

`Jenkins` is the user set for commits created by our automation during releases.

`menski` & `hawky-4s-` are previus camundis

`skjolber` contributed with a single commit to introduce xquery script engine:

git log --author="skjolber" --pretty=format:"%h - %s"
52c17f5 - feat(xquery):add xquery script engine

git log --grep='Co-authored-by: skjolber'
# no result

xquery script engine has been removed from camunda-template-engines-jsr223 repo and moved to the Community Hub. As skjolber contribution has been already removed we don't need a signed CLA to merge this commit.

After consulting with @tasso94 and the FOSS team, we have confirmed that it is appropriate to merge the changes given the current CLA check results.

mboskamp commented 5 months ago

👍 Well done @venetrius! This looks very clean. I added one remark about cleaning up the automation that updates the NOTICE files. We should do that in a separate PR. Details in the PR.

venetrius commented 5 months ago

👍 Well done @venetrius! This looks very clean. I added one remark about cleaning up the automation that updates the NOTICE files. We should do that in a separate PR. Details in the PR.

Thanks, @mboskamp! Created PR to update the automation: https://github.com/camunda/camunda-bpm-helper-resources/pull/7

venetrius commented 5 months ago

QA note: @gbetances089 no functional change.

camunda / camunda-bpm-platform