search

camunda / camunda-bpm-platform

Flexible framework for workflow and decision automation with BPMN and DMN. Integration with Quarkus, Spring, Spring Boot, CDI.
https://camunda.com/
Apache License 2.0
4.03k stars 1.53k forks source link

4229 date filter #4305

Open punitdarira opened 2 months ago

punitdarira commented 2 months ago

Telemetry API now has metrics and date filter. Made changes in telemetry and metrics api to reuse code.

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

danielkelemen commented 2 months ago

Hi @punitdarira, thank you for your PR!

I'd need a bit more time to review this thoroughly. It already looks pretty good at first sight. I can already tell you, that we would need a few more tests in the TelemetryRestServiceTest for instance, to test the newly added parameters and the results. But I'll provide more feedback soon.

-Daniel

punitdarira commented 2 months ago

Hi @punitdarira, thank you for your PR!

I'd need a bit more time to review this thoroughly. It already looks pretty good at first sight. I can already tell you, that we would need a few more tests in the TelemetryRestServiceTest for instance, to test the newly added parameters and the results. But I'll provide more feedback soon.

-Daniel

Hi @danielkelemen, I agree regarding the tests. I'll update this PR with the tests.