search

camunda / camunda-bpm-platform

Flexible framework for workflow and decision automation with BPMN and DMN. Integration with Quarkus, Spring, Spring Boot, CDI.
https://camunda.com/
Apache License 2.0
4.1k stars 1.55k forks source link

4194 move commons into platform #4309

Closed venetrius closed 4 months ago

venetrius commented 5 months ago

Related to: https://github.com/camunda/camunda-bpm-platform/issues/4194

Only review code changes not inherited from commons, starting at commit: https://github.com/camunda/camunda-bpm-platform/commit/47c9a8512d9bff59c5a1dfc7896b78370b58344f https://github.com/camunda/camunda-bpm-platform/pull/4309/files/dd61e25e23ce8d9b4c5714d921e29e4c2c6c55ac..262801cc85063a01e9177f5ef1acc55dbb960be6

CLAassistant commented 5 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: psavidis
:x: ci.cambpm

ci.cambpm seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

venetrius commented 5 months ago

CLA assistant check ✅ psavidis❌ ci.cambpm

ci.cambpm is the githandle used for automatic updates in the release process.

venetrius commented 4 months ago

Merging, previus build succeded: https://ci-pipeline.cambpm.camunda.cloud/blue/organizations/jenkins/7.22%2Fcambpm-ce%2Fcambpm-main/detail/PR-4309/25/pipeline only change is a removal of an block from a pom, https://github.com/camunda/camunda-bpm-platform/pull/4309#discussion_r1594140521.