Closed venetrius closed 1 week ago
Tomcat and Engine bug fixes to update all connec-connectors-all
usage.
And one PR to resolve spin-dataformat-all
usages
To verify my changes I compared the mvn dependency:tree
result for each modules that has a direct dependency on connectors-all or spin-dataformat-all.
Comparing Master (before PR-s applies): dependencies-master.log Master after 7.21.0 is released: dependencies-7-21.log Dependencies after PR changer are applied: dependency-applied-changes.log
@venetrius don't forget to add the version labels to this ticket and and the subtasks. Starting a tomcat distro on Mac can be done as sanity a check before completing this. We can also trigger a dry run of a snapshot for the docker images once the changes are merged.
Thanks @yanavasileva, I added the labels, and will smoke test all distros before completing this issue.
Run smoke test successfully for distributions
docker run --rm -it -p 8088:8080 registry.camunda.cloud/cambpm-ee/camunda-bpm-platform-ee:tomcat-7.22.0-SNAPSHOT
docker run --rm -it -p 8088:8080 registry.camunda.cloud/cambpm-ee/camunda-bpm-platform-ee:run-7.22.0-SNAPSHOT
docker run --rm -it -p 8088:8080 registry.camunda.cloud/cambpm-ee/camunda-bpm-platform-ee:wildfly-7.22.0-SNAPSHOT
setting db to h2 and using app template: WebLogic 14R1 (autosetup): Camunda Platform 7.22.x
Since 7.20 we only use WebSphere Liberty and App Template has not been created in Portainer Deployed locally 7.22.0-SNAPSHOT following internal docs and tested successfully
Acceptance Criteria (Required on creation)
When importing a module that uses the Maven Shade Plugin all dependencies that are shaded out should be excluded to make sure no unintended artefacts are included in the builds.
During #3682 Connect, Commons & Spin has been moved into the platform mono repo. Some of the modules contained in these projects are using the Shade plugin to create a fat jar. Moving these projects to the mono-repo had the implications that the Maven Reactor is updated with the transitive shaded dependencies. Apache Felix Maven Bundle Plugin will build the jar based on the Maven Reactor, without considering the Maven Shade Plugin settings.
This caused a few issues: engine unit test failing related to connect httpclient is a runtime dependency in engine. - Related to connect Java external client build fails during Assembly stage. - Related to Spin
Hints
Example: https://github.com/camunda/camunda-bpm-platform/pull/4416/files
Modules that were merged and are using shading:
camunda-connect-connectors-all
:used in:
camunda-external-task-client-root
,camunda-bpm-run-core
,camunda-tomcat
,engine
,qa-plugins-spin-dataformat-all
,qa-plugins-spin
camunda-spin-dataformat-all
:used in:
engine
,camunda-tomcat
Links
Breakdown
Dev2QA handover