camunda / camunda-bpm-platform

Flexible framework for workflow and decision automation with BPMN and DMN. Integration with Quarkus, Spring, Spring Boot, CDI.
https://camunda.com/
Apache License 2.0
4.02k stars 1.53k forks source link

Exclude shaded transitive dependencies #4417

Closed venetrius closed 1 week ago

venetrius commented 3 weeks ago

Acceptance Criteria (Required on creation)

When importing a module that uses the Maven Shade Plugin all dependencies that are shaded out should be excluded to make sure no unintended artefacts are included in the builds.

During #3682 Connect, Commons & Spin has been moved into the platform mono repo. Some of the modules contained in these projects are using the Shade plugin to create a fat jar. Moving these projects to the mono-repo had the implications that the Maven Reactor is updated with the transitive shaded dependencies. Apache Felix Maven Bundle Plugin will build the jar based on the Maven Reactor, without considering the Maven Shade Plugin settings.

This caused a few issues: engine unit test failing related to connect httpclient is a runtime dependency in engine. - Related to connect Java external client build fails during Assembly stage. - Related to Spin

Hints

Example: https://github.com/camunda/camunda-bpm-platform/pull/4416/files

Modules that were merged and are using shading:

camunda-connect-connectors-all:

used in: camunda-external-task-client-root, camunda-bpm-run-core, camunda-tomcat, engine, qa-plugins-spin-dataformat-all, qa-plugins-spin

camunda-spin-dataformat-all:

used in: engine, camunda-tomcat

Links

Breakdown

### Sub Tasks
- [ ] https://github.com/camunda/camunda-bpm-platform/issues/4422
- [ ] https://github.com/camunda/camunda-bpm-platform/issues/4414
- [ ] https://github.com/camunda/camunda-bpm-platform/issues/4427

Dev2QA handover

venetrius commented 2 weeks ago

Tomcat and Engine bug fixes to update all connec-connectors-all usage. And one PR to resolve spin-dataformat-all usages

venetrius commented 2 weeks ago

To verify my changes I compared the mvn dependency:tree result for each modules that has a direct dependency on connectors-all or spin-dataformat-all.

Comparing Master (before PR-s applies): dependencies-master.log Master after 7.21.0 is released: dependencies-7-21.log Dependencies after PR changer are applied: dependency-applied-changes.log

Below are the module difference between 7.21 and after PR changes are applied.

tomcat same differences for `camunda-tomcat-assembly` and for `camunda-bpm-tomcat` only showing `camunda-tomcat-assembly` ``` diff [INFO] --- dependency:2.8:tree (default-cli) @ camunda-tomcat-assembly --- [INFO] org.camunda.bpm.tomcat:camunda-tomcat-assembly:pom:7.22.0-SNAPSHOT [INFO] +- org.apache.tomcat:tomcat:tar.gz:9.0.85:compile [INFO] +- com.h2database:h2:jar:2.1.214:compile [INFO] +- org.mybatis:mybatis:jar:3.5.15:compile [INFO] +- com.fasterxml.uuid:java-uuid-generator:jar:4.3.0:compile [INFO] | \- org.slf4j:slf4j-api:jar:1.7.36:compile [INFO] +- org.codehaus.groovy:groovy:jar:2.4.21:compile [INFO] +- org.codehaus.groovy:groovy-jsr223:jar:2.4.21:compile [INFO] +- org.codehaus.groovy:groovy-json:jar:2.4.21:compile [INFO] +- org.codehaus.groovy:groovy-xml:jar:2.4.21:compile [INFO] +- org.codehaus.groovy:groovy-templates:jar:2.4.21:compile [INFO] +- org.graalvm.js:js:jar:21.1.0:compile [INFO] | +- org.graalvm.regex:regex:jar:21.1.0:compile [INFO] | +- org.graalvm.truffle:truffle-api:jar:21.1.0:compile [INFO] | +- org.graalvm.sdk:graal-sdk:jar:21.1.0:compile [INFO] | \- com.ibm.icu:icu4j:jar:68.2:compile [INFO] +- org.graalvm.js:js-scriptengine:jar:21.1.0:compile [INFO] +- org.camunda.bpm:camunda-engine:jar:7.22.0-SNAPSHOT:compile [INFO] | +- org.camunda.bpm.model:camunda-bpmn-model:jar:7.22.0-SNAPSHOT:compile [INFO] | | \- org.camunda.bpm.model:camunda-xml-model:jar:7.22.0-SNAPSHOT:compile [INFO] | +- org.camunda.bpm.model:camunda-cmmn-model:jar:7.22.0-SNAPSHOT:compile [INFO] | +- org.camunda.bpm.juel:camunda-juel:jar:7.22.0-SNAPSHOT:compile [INFO] | +- org.camunda.bpm.dmn:camunda-engine-dmn:jar:7.22.0-SNAPSHOT:compile [INFO] | | +- org.camunda.bpm.model:camunda-dmn-model:jar:7.22.0-SNAPSHOT:compile [INFO] | | +- org.camunda.bpm.dmn:camunda-engine-feel-api:jar:7.22.0-SNAPSHOT:compile [INFO] | | +- org.camunda.bpm.dmn:camunda-engine-feel-juel:jar:7.22.0-SNAPSHOT:compile [INFO] | | +- org.camunda.bpm.dmn:camunda-engine-feel-scala:jar:7.22.0-SNAPSHOT:compile [INFO] | | \- org.camunda.feel:feel-engine:jar:scala-shaded:1.17.5:compile -[INFO] | +- org.camunda.commons:camunda-commons-logging:jar:1.13.0:compile +[INFO] | +- org.camunda.commons:camunda-commons-logging:jar:7.22.0-SNAPSHOT:compile [INFO] | +- org.camunda.commons:camunda-commons-typed-values:jar:7.22.0-SNAPSHOT:compile [INFO] | +- joda-time:joda-time:jar:2.12.5:compile [INFO] | \- com.google.code.gson:gson:jar:2.8.9:compile [INFO] +- org.camunda.bpm:camunda-engine-cdi:jar:7.22.0-SNAPSHOT:compile [INFO] +- org.camunda.bpm.identity:camunda-identity-ldap:jar:7.22.0-SNAPSHOT:compile -[INFO] +- org.camunda.spin:camunda-spin-core:jar:1.23.0:compile -[INFO] | \- org.camunda.commons:camunda-commons-utils:jar:1.13.0:compile +[INFO] +- org.camunda.spin:camunda-spin-core:jar:7.22.0-SNAPSHOT:compile +[INFO] | \- org.camunda.commons:camunda-commons-utils:jar:7.22.0-SNAPSHOT:compile [INFO] +- org.camunda.bpm:camunda-engine-plugin-spin:jar:7.22.0-SNAPSHOT:compile -[INFO] +- org.camunda.spin:camunda-spin-dataformat-all:jar:1.23.0:compile -[INFO] +- org.camunda.connect:camunda-connect-core:jar:1.6.0:compile +[INFO] +- org.camunda.spin:camunda-spin-dataformat-all:jar:7.22.0-SNAPSHOT:compile +[INFO] +- org.camunda.connect:camunda-connect-core:jar:7.22.0-SNAPSHOT:compile [INFO] +- org.camunda.bpm:camunda-engine-plugin-connect:jar:7.22.0-SNAPSHOT:compile -[INFO] +- org.camunda.connect:camunda-connect-connectors-all:jar:1.6.0:compile +[INFO] +- org.camunda.connect:camunda-connect-connectors-all:jar:7.22.0-SNAPSHOT:compile [INFO] +- org.camunda.bpm:license-book:zip:7.22.0-SNAPSHOT:compile -[INFO] +- org.camunda.template-engines:camunda-template-engines-freemarker:jar:2.2.0:compile +[INFO] +- org.camunda.template-engines:camunda-template-engines-freemarker:jar:7.22.0-SNAPSHOT:compile [INFO] | \- org.freemarker:freemarker:jar:2.3.31:compile [INFO] \- org.slf4j:slf4j-jdk14:jar:1.7.26:compile ```
camunda-external-task-client ``` diff [INFO] --- dependency:2.8:tree (default-cli) @ camunda-external-task-client --- [INFO] org.camunda.bpm:camunda-external-task-client:jar:7.22.0-SNAPSHOT -[INFO] +- org.camunda.commons:camunda-commons-logging:jar:1.13.0:compile +[INFO] +- org.camunda.commons:camunda-commons-logging:jar:7.22.0-SNAPSHOT:compile [INFO] | \- org.slf4j:slf4j-api:jar:1.7.26:compile [INFO] +- org.camunda.commons:camunda-commons-typed-values:jar:7.22.0-SNAPSHOT:compile -[INFO] | \- org.camunda.commons:camunda-commons-utils:jar:1.13.0:compile +[INFO] | \- org.camunda.commons:camunda-commons-utils:jar:7.22.0-SNAPSHOT:compile [INFO] +- org.apache.httpcomponents.client5:httpclient5:jar:5.3:compile [INFO] | +- org.apache.httpcomponents.core5:httpcore5:jar:5.2.4:compile [INFO] | \- org.apache.httpcomponents.core5:httpcore5-h2:jar:5.2.4:compile [INFO] +- com.fasterxml.jackson.core:jackson-databind:jar:2.15.2:compile [INFO] | +- com.fasterxml.jackson.core:jackson-annotations:jar:2.15.2:compile [INFO] | \- com.fasterxml.jackson.core:jackson-core:jar:2.15.2:compile [INFO] +- junit:junit:jar:4.13.1:test [INFO] | \- org.hamcrest:hamcrest-core:jar:1.3:test [INFO] +- org.slf4j:jcl-over-slf4j:jar:1.7.26:test [INFO] +- org.assertj:assertj-core:jar:2.9.1:test [INFO] +- org.camunda.bpm.model:camunda-bpmn-model:jar:7.22.0-SNAPSHOT:test [INFO] | \- org.camunda.bpm.model:camunda-xml-model:jar:7.22.0-SNAPSHOT:test [INFO] +- org.skyscreamer:jsonassert:jar:1.5.0:test [INFO] | \- com.vaadin.external.google:android-json:jar:0.0.20131108.vaadin1:test -[INFO] +- org.camunda.spin:camunda-spin-dataformat-all:jar:1.23.0:test -[INFO] | \- org.camunda.spin:camunda-spin-core:jar:1.23.0:test +[INFO] +- org.camunda.spin:camunda-spin-dataformat-all:jar:7.22.0-SNAPSHOT:test [INFO] +- org.camunda.bpm.qa:engine-variable-test:jar:classes:7.22.0-SNAPSHOT:test [INFO] +- org.camunda.bpm.tomcat:camunda-tomcat-assembly:tar.gz:7.22.0-SNAPSHOT:test [INFO] | +- org.apache.tomcat:tomcat:tar.gz:9.0.85:test [INFO] | +- org.mybatis:mybatis:jar:3.5.15:test [INFO] | +- com.fasterxml.uuid:java-uuid-generator:jar:4.3.0:test [INFO] | +- org.codehaus.groovy:groovy:jar:2.4.21:test [INFO] | +- org.codehaus.groovy:groovy-jsr223:jar:2.4.21:test [INFO] | +- org.codehaus.groovy:groovy-json:jar:2.4.21:test [INFO] | +- org.codehaus.groovy:groovy-xml:jar:2.4.21:test [INFO] | +- org.codehaus.groovy:groovy-templates:jar:2.4.21:test [INFO] | +- org.graalvm.js:js:jar:21.1.0:test [INFO] | | +- org.graalvm.regex:regex:jar:21.1.0:test [INFO] | | +- org.graalvm.truffle:truffle-api:jar:21.1.0:test [INFO] | | +- org.graalvm.sdk:graal-sdk:jar:21.1.0:test [INFO] | | \- com.ibm.icu:icu4j:jar:68.2:test [INFO] | +- org.graalvm.js:js-scriptengine:jar:21.1.0:test [INFO] | +- org.camunda.bpm:camunda-engine:jar:7.22.0-SNAPSHOT:test [INFO] | | +- org.camunda.bpm.model:camunda-cmmn-model:jar:7.22.0-SNAPSHOT:test [INFO] | | +- org.camunda.bpm.juel:camunda-juel:jar:7.22.0-SNAPSHOT:test [INFO] | | +- org.camunda.bpm.dmn:camunda-engine-dmn:jar:7.22.0-SNAPSHOT:test [INFO] | | | +- org.camunda.bpm.model:camunda-dmn-model:jar:7.22.0-SNAPSHOT:test [INFO] | | | +- org.camunda.bpm.dmn:camunda-engine-feel-api:jar:7.22.0-SNAPSHOT:test [INFO] | | | +- org.camunda.bpm.dmn:camunda-engine-feel-juel:jar:7.22.0-SNAPSHOT:test [INFO] | | | +- org.camunda.bpm.dmn:camunda-engine-feel-scala:jar:7.22.0-SNAPSHOT:test [INFO] | | | \- org.camunda.feel:feel-engine:jar:scala-shaded:1.17.5:test [INFO] | | +- joda-time:joda-time:jar:2.12.5:test [INFO] | | \- com.google.code.gson:gson:jar:2.8.9:test [INFO] | +- org.camunda.bpm:camunda-engine-cdi:jar:7.22.0-SNAPSHOT:test [INFO] | +- org.camunda.bpm.identity:camunda-identity-ldap:jar:7.22.0-SNAPSHOT:test +[INFO] | +- org.camunda.spin:camunda-spin-core:jar:7.22.0-SNAPSHOT:test [INFO] | +- org.camunda.bpm:camunda-engine-plugin-spin:jar:7.22.0-SNAPSHOT:test -[INFO] | +- org.camunda.connect:camunda-connect-core:jar:1.6.0:test +[INFO] | +- org.camunda.connect:camunda-connect-core:jar:7.22.0-SNAPSHOT:test [INFO] | +- org.camunda.bpm:camunda-engine-plugin-connect:jar:7.22.0-SNAPSHOT:test -[INFO] | +- org.camunda.connect:camunda-connect-connectors-all:jar:1.6.0:test +[INFO] | +- org.camunda.connect:camunda-connect-connectors-all:jar:7.22.0-SNAPSHOT:test [INFO] | +- org.camunda.bpm:license-book:zip:7.22.0-SNAPSHOT:test -[INFO] | +- org.camunda.template-engines:camunda-template-engines-freemarker:jar:2.2.0:test +[INFO] | +- org.camunda.template-engines:camunda-template-engines-freemarker:jar:7.22.0-SNAPSHOT:test [INFO] | | \- org.freemarker:freemarker:jar:2.3.31:test [INFO] | \- org.slf4j:slf4j-jdk14:jar:1.7.26:test [INFO] +- org.camunda.bpm:camunda-engine-rest:war:tomcat:7.22.0-SNAPSHOT:test [INFO] +- org.camunda.bpm.qa:engine-variable-test:war:7.22.0-SNAPSHOT:test [INFO] +- com.sun.xml.bind:jaxb-impl:jar:4.0.5:provided [INFO] | \- com.sun.xml.bind:jaxb-core:jar:4.0.5:provided [INFO] | +- jakarta.xml.bind:jakarta.xml.bind-api:jar:4.0.2:provided [INFO] | | \- jakarta.activation:jakarta.activation-api:jar:2.1.3:provided [INFO] | \- org.eclipse.angus:angus-activation:jar:2.0.2:provided [INFO] +- org.mockito:mockito-core:jar:5.10.0:test [INFO] | +- net.bytebuddy:byte-buddy:jar:1.14.11:test [INFO] | +- net.bytebuddy:byte-buddy-agent:jar:1.14.11:test [INFO] | \- org.objenesis:objenesis:jar:3.3:test [INFO] \- com.h2database:h2:jar:2.1.214:test ```
camunda-bpm-run-core lot of minor version change, related: A few lib (slf4j-api:jar, camunda-commons-utils:jar) has been resolved from a different path but the result is the same ``` diff [INFO] --- dependency:2.8:tree (default-cli) @ camunda-bpm-run-core --- [INFO] org.camunda.bpm.run:camunda-bpm-run-core:jar:7.22.0-SNAPSHOT [INFO] +- org.camunda.bpm.springboot:camunda-bpm-spring-boot-starter:jar:7.22.0-SNAPSHOT:compile ... [INFO] | +- com.fasterxml.uuid:java-uuid-generator:jar:4.3.0:compile +[INFO] | | \- org.slf4j:slf4j-api:jar:2.0.13:compile ... [INFO] +- org.camunda.bpm:camunda-engine-plugin-spin:jar:7.22.0-SNAPSHOT:compile -[INFO] | \- org.camunda.spin:camunda-spin-core:jar:1.23.0:compile +[INFO] | \- org.camunda.spin:camunda-spin-core:jar:7.22.0-SNAPSHOT:compile +[INFO] | \- org.camunda.commons:camunda-commons-utils:jar:7.22.0-SNAPSHOT:compile ... [INFO] +- org.camunda.bpm:camunda-engine-plugin-connect:jar:7.22.0-SNAPSHOT:compile -[INFO] | \- org.camunda.connect:camunda-connect-core:jar:1.6.0:compile +[INFO] | \- org.camunda.connect:camunda-connect-core:jar:7.22.0-SNAPSHOT:compile -[INFO] +- org.camunda.spin:camunda-spin-dataformat-all:jar:1.23.0:compile +[INFO] +- org.camunda.spin:camunda-spin-dataformat-all:jar:7.22.0-SNAPSHOT:compile -[INFO] | +- org.camunda.commons:camunda-commons-logging:jar:1.13.0:compile -[INFO] | +- org.slf4j:slf4j-api:jar:2.0.11:compile -[INFO] | \- org.camunda.commons:camunda-commons-utils:jar:1.13.0:compile ... [INFO] +- org.camunda.bpm.identity:camunda-identity-ldap:jar:7.22.0-SNAPSHOT:compile +[INFO] | \- org.camunda.commons:camunda-commons-logging:jar:7.22.0-SNAPSHOT:compile ```
qa-plugins-spin-dataformat-all lot of minor version change, related: A few lib (slf4j-api:jar, camunda-commons-utils:jar) has been resolved from a different path but the result is the same ``` diff [INFO] --- dependency:2.8:tree (default-cli) @ qa-plugins-spin-dataformat-all --- [INFO] org.camunda.bpm.springboot.project:qa-plugins-spin-dataformat-all:jar:7.22.0-SNAPSHOT [INFO] +- org.camunda.bpm.springboot.project:qa-plugins-spin-dataformat-json-jackson:jar:7.22.0-SNAPSHOT:compile [INFO] | +- org.camunda.bpm.springboot:camunda-bpm-spring-boot-starter:jar:7.22.0-SNAPSHOT:compile [INFO] | | +- org.camunda.bpm:camunda-engine-spring-6:jar:7.22.0-SNAPSHOT:compile ... -[INFO] | | | +- org.camunda.connect:camunda-connect-core:jar:1.6.0:compile +[INFO] | | | +- org.camunda.connect:camunda-connect-core:jar:7.22.0-SNAPSHOT:compile -[INFO] | | | \- org.camunda.connect:camunda-connect-connectors-all:jar:1.6.0:runtime +[INFO] | | | \- org.camunda.connect:camunda-connect-connectors-all:jar:7.22.0-SNAPSHOT:runtime ... [INFO] | | +- com.fasterxml.uuid:java-uuid-generator:jar:4.3.0:compile +[INFO] | | | \- org.slf4j:slf4j-api:jar:2.0.13:compile ... [INFO] | +- org.camunda.bpm.springboot:camunda-bpm-spring-boot-starter-test:jar:7.22.0-SNAPSHOT:compile ... +[INFO] | \- org.camunda.spin:camunda-spin-core:jar:7.22.0-SNAPSHOT:compile +[INFO] | +- org.camunda.commons:camunda-commons-logging:jar:7.22.0-SNAPSHOT:compile +[INFO] | \- org.camunda.commons:camunda-commons-utils:jar:7.22.0-SNAPSHOT:compile -[INFO] +- org.camunda.spin:camunda-spin-dataformat-all:jar:1.23.0:compile +[INFO] +- org.camunda.spin:camunda-spin-dataformat-all:jar:7.22.0-SNAPSHOT:compile -[INFO] | +- org.camunda.spin:camunda-spin-core:jar:1.23.0:compile -[INFO] | +- org.camunda.commons:camunda-commons-logging:jar:1.13.0:compile -[INFO] | +- org.slf4j:slf4j-api:jar:2.0.11:compile ```
camunda-engine ``` diff [INFO] --- dependency:2.8:tree (default-cli) @ camunda-engine --- [INFO] org.camunda.bpm:camunda-engine:jar:7.22.0-SNAPSHOT [INFO] +- org.camunda.bpm.model:camunda-bpmn-model:jar:7.22.0-SNAPSHOT:compile [INFO] | \- org.camunda.bpm.model:camunda-xml-model:jar:7.22.0-SNAPSHOT:compile [INFO] +- org.camunda.bpm.model:camunda-cmmn-model:jar:7.22.0-SNAPSHOT:compile [INFO] +- org.camunda.bpm.juel:camunda-juel:jar:7.22.0-SNAPSHOT:compile [INFO] +- org.camunda.bpm.dmn:camunda-engine-dmn:jar:7.22.0-SNAPSHOT:compile -[INFO] | +- org.camunda.commons:camunda-commons-utils:jar:1.13.0:compile +[INFO] | +- org.camunda.commons:camunda-commons-utils:jar:7.22.0-SNAPSHOT:compile [INFO] | +- org.camunda.bpm.model:camunda-dmn-model:jar:7.22.0-SNAPSHOT:compile [INFO] | +- org.camunda.bpm.dmn:camunda-engine-feel-api:jar:7.22.0-SNAPSHOT:compile [INFO] | +- org.camunda.bpm.dmn:camunda-engine-feel-juel:jar:7.22.0-SNAPSHOT:compile [INFO] | +- org.camunda.bpm.dmn:camunda-engine-feel-scala:jar:7.22.0-SNAPSHOT:compile [INFO] | \- org.camunda.feel:feel-engine:jar:scala-shaded:1.17.5:compile -[INFO] +- org.camunda.commons:camunda-commons-logging:jar:1.13.0:compile +[INFO] +- org.camunda.commons:camunda-commons-logging:jar:7.22.0-SNAPSHOT:compile [INFO] | \- org.slf4j:slf4j-api:jar:1.7.26:compile [INFO] +- org.camunda.commons:camunda-commons-typed-values:jar:7.22.0-SNAPSHOT:compile [INFO] +- org.mybatis:mybatis:jar:3.5.15:compile +# unrelated -[INFO] +- org.springframework:spring-beans:jar:5.3.27:compile -[INFO] | \- org.springframework:spring-core:jar:5.3.27:compile -[INFO] | \- org.springframework:spring-jcl:jar:5.3.27:compile +[INFO] +- org.springframework:spring-beans:jar:5.3.36:compile +[INFO] | \- org.springframework:spring-core:jar:5.3.36:compile +[INFO] | \- org.springframework:spring-jcl:jar:5.3.36:compile +# unreleated [INFO] +- joda-time:joda-time:jar:2.12.5:compile [INFO] +- com.google.code.gson:gson:jar:2.8.9:compile -[INFO] +- org.camunda.connect:camunda-connect-core:jar:1.6.0:compile +[INFO] +- org.camunda.connect:camunda-connect-core:jar:7.22.0-SNAPSHOT:compile -[INFO] +- org.camunda.connect:camunda-connect-connectors-all:jar:1.6.0:runtime +[INFO] +- org.camunda.connect:camunda-connect-connectors-all:jar:7.22.0-SNAPSHOT:runtime [INFO] +- org.apache.ant:ant:jar:1.7.1:provided [INFO] | \- org.apache.ant:ant-launcher:jar:1.7.1:provided [INFO] +- org.apache.geronimo.specs:geronimo-jta_1.1_spec:jar:1.1.1:provided [INFO] +- com.fasterxml.uuid:java-uuid-generator:jar:4.3.0:provided [INFO] +- org.jboss.spec:jboss-javaee-web-6.0:pom:3.0.2.Final:provided [INFO] | +- javax.enterprise:cdi-api:jar:1.0-SP4:provided [INFO] | +- javax.inject:javax.inject:jar:1:provided [INFO] | +- javax.validation:validation-api:jar:1.0.0.GA:provided [INFO] | +- org.hibernate.javax.persistence:hibernate-jpa-2.0-api:jar:1.0.1.Final:provided [INFO] | +- org.jboss.spec.javax.annotation:jboss-annotations-api_1.1_spec:jar:1.0.1.Final:provided [INFO] | +- org.jboss.spec.javax.ejb:jboss-ejb-api_3.1_spec:jar:1.0.2.Final:provided [INFO] | +- org.jboss.spec.javax.el:jboss-el-api_2.2_spec:jar:1.0.2.Final:provided [INFO] | +- org.jboss.spec.javax.faces:jboss-jsf-api_2.1_spec:jar:2.0.9.Final:provided [INFO] | +- org.jboss.spec.javax.interceptor:jboss-interceptors-api_1.1_spec:jar:1.0.1.Final:provided [INFO] | +- org.jboss.spec.javax.resource:jboss-connector-api_1.6_spec:jar:1.0.1.Final:provided [INFO] | +- org.jboss.spec.javax.security.auth.message:jboss-jaspi-api_1.0_spec:jar:1.0.1.Final:provided [INFO] | +- org.jboss.spec.javax.servlet:jboss-servlet-api_3.0_spec:jar:1.0.2.Final:provided [INFO] | +- org.jboss.spec.javax.servlet.jsp:jboss-jsp-api_2.2_spec:jar:1.0.1.Final:provided [INFO] | +- org.jboss.spec.javax.servlet.jstl:jboss-jstl-api_1.2_spec:jar:1.0.3.Final:provided [INFO] | | \- xalan:xalan:jar:2.7.1.jbossorg-2:provided [INFO] | | \- xalan:serializer:jar:2.7.1.jbossorg-2:provided [INFO] | +- org.jboss.spec.javax.transaction:jboss-transaction-api_1.1_spec:jar:1.0.1.Final:provided [INFO] | +- org.jboss.spec.javax.ws.rs:jboss-jaxrs-api_1.1_spec:jar:1.0.1.Final:provided [INFO] | \- org.jboss.spec.javax.xml.bind:jboss-jaxb-api_2.2_spec:jar:1.0.4.Final:provided [INFO] +- jakarta.transaction:jakarta.transaction-api:jar:2.0.1:provided [INFO] +- jakarta.servlet:jakarta.servlet-api:jar:6.0.0:provided [INFO] +- jakarta.ejb:jakarta.ejb-api:jar:4.0.1:provided [INFO] +- org.apache.tomcat:catalina:jar:6.0.37:provided [INFO] | +- org.apache.tomcat:servlet-api:jar:6.0.37:provided [INFO] | +- org.apache.tomcat:juli:jar:6.0.37:provided [INFO] | \- org.apache.tomcat:annotations-api:jar:6.0.37:provided [INFO] +- org.jboss:jboss-vfs:jar:3.1.0.Final:provided [INFO] | \- org.jboss.logging:jboss-logging:jar:3.0.0.CR1:provided [INFO] +- org.apache.commons:commons-email:jar:1.5:provided [INFO] | \- com.sun.mail:javax.mail:jar:1.5.6:provided [INFO] | \- javax.activation:activation:jar:1.1:provided [INFO] +- junit:junit:jar:4.13.1:provided [INFO] | \- org.hamcrest:hamcrest-core:jar:1.3:provided [INFO] +- org.mockito:mockito-core:jar:5.10.0:test [INFO] | +- net.bytebuddy:byte-buddy:jar:1.14.11:test [INFO] | +- net.bytebuddy:byte-buddy-agent:jar:1.14.11:test [INFO] | \- org.objenesis:objenesis:jar:3.3:test [INFO] +- com.h2database:h2:jar:2.1.214:test [INFO] +- commons-collections:commons-collections:jar:3.2.2:test [INFO] +- org.subethamail:subethasmtp-wiser:jar:1.2:test [INFO] | +- org.subethamail:subethasmtp-smtp:jar:1.2:test [INFO] | +- commons-logging:commons-logging:jar:1.1.1:test [INFO] | \- javax.mail:mail:jar:1.4:test [INFO] +- commons-io:commons-io:jar:2.8.0:test -[INFO] +- org.springframework:spring-test:jar:5.3.27:test +[INFO] +- org.springframework:spring-test:jar:5.3.36:test -[INFO] +- org.apache.commons:commons-lang3:jar:3.8.1:test +[INFO] +- org.camunda.commons:camunda-commons-testing:jar:7.22.0-SNAPSHOT:test [INFO] +- org.camunda.commons:camunda-commons-testing:jar:1.13.0:test [INFO] +- org.camunda.bpm:camunda-test-utils-testcontainers:jar:7.22.0-SNAPSHOT:test [INFO] | +- org.testcontainers:testcontainers:jar:1.16.0:test [INFO] | | +- org.apache.commons:commons-compress:jar:1.20:test [INFO] | | +- org.rnorth.duct-tape:duct-tape:jar:1.0.8:test [INFO] | | +- com.github.docker-java:docker-java-api:jar:3.2.11:test [INFO] | | \- com.github.docker-java:docker-java-transport-zerodep:jar:3.2.11:test [INFO] | | +- com.github.docker-java:docker-java-transport:jar:3.2.11:test [INFO] | | \- net.java.dev.jna:jna:jar:5.8.0:test [INFO] | +- org.testcontainers:mysql:jar:1.16.0:test [INFO] | | \- org.testcontainers:jdbc:jar:1.16.0:test [INFO] | | \- org.testcontainers:database-commons:jar:1.16.0:test [INFO] | +- org.testcontainers:mariadb:jar:1.16.0:test [INFO] | +- org.testcontainers:postgresql:jar:1.16.0:test [INFO] | +- org.testcontainers:mssqlserver:jar:1.16.0:test [INFO] | \- org.testcontainers:cockroachdb:jar:1.16.0:test [INFO] +- org.hamcrest:hamcrest-library:jar:1.3:test [INFO] +- org.assertj:assertj-core:jar:2.9.1:test [INFO] +- ch.qos.logback:logback-classic:jar:1.2.11:test [INFO] | \- ch.qos.logback:logback-core:jar:1.2.11:test [INFO] +- org.slf4j:jcl-over-slf4j:jar:1.7.26:test [INFO] +- org.slf4j:jul-to-slf4j:jar:1.7.26:test [INFO] +- com.github.tomakehurst:wiremock:jar:2.27.2:test [INFO] | +- org.eclipse.jetty:jetty-server:jar:9.2.28.v20190418:test [INFO] | | +- javax.servlet:javax.servlet-api:jar:3.1.0:test [INFO] | | +- org.eclipse.jetty:jetty-http:jar:9.2.28.v20190418:test [INFO] | | \- org.eclipse.jetty:jetty-io:jar:9.2.28.v20190418:test [INFO] | +- org.eclipse.jetty:jetty-servlet:jar:9.2.28.v20190418:test [INFO] | | \- org.eclipse.jetty:jetty-security:jar:9.2.28.v20190418:test [INFO] | +- org.eclipse.jetty:jetty-servlets:jar:9.2.28.v20190418:test [INFO] | | +- org.eclipse.jetty:jetty-continuation:jar:9.2.28.v20190418:test [INFO] | | \- org.eclipse.jetty:jetty-util:jar:9.2.28.v20190418:test [INFO] | +- org.eclipse.jetty:jetty-webapp:jar:9.2.28.v20190418:test [INFO] | | \- org.eclipse.jetty:jetty-xml:jar:9.2.28.v20190418:test [INFO] | +- org.eclipse.jetty:jetty-proxy:jar:9.2.28.v20190418:test [INFO] | | \- org.eclipse.jetty:jetty-client:jar:9.2.28.v20190418:test [INFO] | +- com.google.guava:guava:jar:20.0:test [INFO] | +- com.fasterxml.jackson.core:jackson-core:jar:2.11.0:test [INFO] | +- com.fasterxml.jackson.core:jackson-annotations:jar:2.11.0:test [INFO] | +- com.fasterxml.jackson.core:jackson-databind:jar:2.11.0:test [INFO] | +- org.apache.httpcomponents:httpclient:jar:4.5.12:test [INFO] | | +- org.apache.httpcomponents:httpcore:jar:4.4.13:test [INFO] | | \- commons-codec:commons-codec:jar:1.11:test [INFO] | +- org.xmlunit:xmlunit-core:jar:2.6.2:test [INFO] | | \- javax.xml.bind:jaxb-api:jar:2.3.0:test [INFO] | +- org.xmlunit:xmlunit-legacy:jar:2.7.0:test [INFO] | +- org.xmlunit:xmlunit-placeholders:jar:2.7.0:test [INFO] | +- com.jayway.jsonpath:json-path:jar:2.4.0:test [INFO] | | \- net.minidev:json-smart:jar:2.3:test [INFO] | | \- net.minidev:accessors-smart:jar:1.2:test [INFO] | +- org.ow2.asm:asm:jar:7.0:test [INFO] | +- net.sf.jopt-simple:jopt-simple:jar:5.0.3:test [INFO] | +- com.github.jknack:handlebars:jar:4.0.7:test [INFO] | | \- org.antlr:antlr4-runtime:jar:4.7.1:test [INFO] | +- com.github.jknack:handlebars-helpers:jar:4.0.7:test [INFO] | +- com.flipkart.zjsonpatch:zjsonpatch:jar:0.4.4:test [INFO] | \- commons-fileupload:commons-fileupload:jar:1.5:test [INFO] +- org.codehaus.groovy:groovy-jsr223:jar:2.4.21:test [INFO] | \- org.codehaus.groovy:groovy:jar:2.4.21:test [INFO] +- org.python:jython:jar:2.5.3:test [INFO] +- org.jruby:jruby-complete:jar:9.1.17.0:test [INFO] +- org.graalvm.js:js:jar:21.1.0:test [INFO] | +- org.graalvm.regex:regex:jar:21.1.0:test [INFO] | +- org.graalvm.truffle:truffle-api:jar:21.1.0:test [INFO] | +- org.graalvm.sdk:graal-sdk:jar:21.1.0:test [INFO] | \- com.ibm.icu:icu4j:jar:68.2:test [INFO] +- org.graalvm.js:js-scriptengine:jar:21.1.0:test [INFO] \- org.camunda.bpm:camunda-bpm-archunit:jar:7.22.0-SNAPSHOT:test [INFO] \- com.tngtech.archunit:archunit-junit4:jar:1.0.1:test [INFO] \- com.tngtech.archunit:archunit:jar:1.0.1:test ```
yanavasileva commented 2 weeks ago

@venetrius don't forget to add the version labels to this ticket and and the subtasks. Starting a tomcat distro on Mac can be done as sanity a check before completing this. We can also trigger a dry run of a snapshot for the docker images once the changes are merged.

venetrius commented 2 weeks ago

Thanks @yanavasileva, I added the labels, and will smoke test all distros before completing this issue.

venetrius commented 2 weeks ago

Run smoke test successfully for distributions

Tested tomcat, run, wildfly loccally via docker

docker run --rm -it -p 8088:8080 registry.camunda.cloud/cambpm-ee/camunda-bpm-platform-ee:tomcat-7.22.0-SNAPSHOT
docker run --rm -it -p 8088:8080 registry.camunda.cloud/cambpm-ee/camunda-bpm-platform-ee:run-7.22.0-SNAPSHOT
docker run --rm -it -p 8088:8080 registry.camunda.cloud/cambpm-ee/camunda-bpm-platform-ee:wildfly-7.22.0-SNAPSHOT

Tested Weblogic on portainer

setting db to h2 and using app template: WebLogic 14R1 (autosetup): Camunda Platform 7.22.x

Tested Websphere

Since 7.20 we only use WebSphere Liberty and App Template has not been created in Portainer Deployed locally 7.22.0-SNAPSHOT following internal docs and tested successfully

venetrius commented 1 week ago

@gbetances089: no QA testing required, I smoke tested distros, see comment. No need to backport this as the original change will only be released with 7.22.0