search

camunda / camunda-bpm-platform

Flexible framework for workflow and decision automation with BPMN and DMN. Integration with Quarkus, Spring, Spring Boot, CDI.
https://camunda.com/
Apache License 2.0
4.02k stars 1.53k forks source link

fix(engine): Added cmmn and dmn checks for db calls #4457

Closed punitdarira closed 5 hours ago

punitdarira commented 6 days ago

related to #3999

yanavasileva commented 4 days ago

Hi @punitdarira,

Thank you for your contribution. The changes look good, I need to run a few tests though. I will keep you posted.

Best, Yana

punitdarira commented 3 days ago

Hi @punitdarira,

Thank you for your contribution. The changes look good, I need to run a few tests though. I will keep you posted.

Best, Yana

Sounds good! @yanavasileva I was wondering are you performing manual test for cockpit or through a regression test suite?

yanavasileva commented 3 days ago

I was wondering are you performing manual test for cockpit or through a regression test suite?

I did both for this PR.

yanavasileva commented 5 hours ago

@punitdarira, thank you for considering my feedback and once again for the contribution. I will merge the code now.